search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.24k stars 4.87k forks source link

Merge nvidia-gpu-device-plugin and nvidia-device-plugin. #19545

Open RamBITS-AI opened 4 weeks ago

RamBITS-AI commented 4 weeks ago

Fixes #19114.

Merged both the addons, nvidia-gpu-device-plugin and nvidia-device-plugin, into nvidia-gpu-device-plugin addon.

BEFORE:

minikube start --driver docker --container-runtime docker --gpus all

PRE-1-minikube-nvidia-gpu-all_docker-driver_container-runtime-docker

minikube status minikube kubectl -- get pods -A

PRE-1-minikube-nvidia-gpu-all_docker-driver_container-runtime-docker_minikube-status_get-pods

minikube addons enable nvidia-device-plugin --alsologtostderr

PRE-1-minikube-nvidia-device-plugin_addons-enable

minikube addons enable nvidia-gpu-device-plugin --alsologtostderr

PRE-1 1-minikube-nvidia-gpu-device-plugin_addons-enable PRE-1 2-minikube-nvidia-gpu-device-plugin_addons-enable

AFTER:

minikube start --driver docker --container-runtime docker --gpus all

POST-minikube-nvidia-gpu-all_docker-driver_container-runtime-docker

minikube status minikube kubectl -- get pods -A

POST-minikube-nvidia-gpu-all_docker-driver_container-runtime-docker_minikube-status_get-pods

minikube addons enable nvidia-device-plugin --alsologtostderr

POST-minikube-nvidia-device-plugin_addons-enable

minikube addons enable nvidia-gpu-device-plugin --alsologtostderr

POST-minikube-nvidia-gpu-device-plugin_addons-enable

minikube kubectl -- logs nvidia-gpu-device-plugin-9q48p -n kube-system

POST-minikube-nvidia-gpu-all_docker-driver_container-runtime-docker_nvidia-gpu-device-plugin-logs

k8s-ci-robot commented 4 weeks ago

Hi @RamBITS-AI. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
minikube-bot commented 4 weeks ago

Can one of the admins verify this patch?

k8s-ci-robot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RamBITS-AI Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment