Logviewer addon update:containerd log format support and some bugfixes

kubernetes / minikube

Run Kubernetes locally

https://minikube.sigs.k8s.io/

Apache License 2.0

29.24k stars 4.87k forks source link

Logviewer addon update:containerd log format support and some bugfixes #19546

Open ivans3 opened 4 weeks ago

ivans3 commented 4 weeks ago

Hi,

Thank you for considering the Pull request. I have an update for the Logviewer addon.

Addon Description: Added in 2018, logviewer addon is an alternative to installing the ELK stack for log aggregation and logviewing through a web-interface. It is a light in-memory application that tails the container log files on disk.

PR Description: adding support and auto-detection of containerd log format. Also some minor fixes for formatting and browser inconsistencies. My team has been testing it for over a month and seems OK

https://github.com/ivans3/minikube-log-viewer (Unilicense)

Thanks! ivans3

k8s-ci-robot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivans3 Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

k8s-ci-robot commented 4 weeks ago

Hi @ivans3. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

minikube-bot commented 4 weeks ago

Can one of the admins verify this patch?

ivans3 commented 1 week ago

Hi @medyagh Sure sounds good. I changed the tag name to v1 and will use v2,v3,etc... for any subsequent updates