kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.24k stars 4.87k forks source link

Update linux command in pushing.md to use docker daemon inside minikube #19552

Open amigueldiez opened 3 weeks ago

amigueldiez commented 3 weeks ago

Description of change

This update corrects a command in the documentation related to using the Docker daemon with Minikube. The previous command was invalid, and it has been replaced with the correct one that properly connects to Minikube's Docker daemon.

Details

By running the following command in the terminal:

$ minikube docker-env

The output is:

export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.67.2:2376"
export DOCKER_CERT_PATH="/home/XXX/.minikube/certs"
export MINIKUBE_ACTIVE_DOCKERD="minikube"

# To point your shell to minikube's docker-daemon, run:
# eval $(minikube -p minikube docker-env)

The command shown at the end (eval $(minikube -p minikube docker-env)) is the one that works and should be used, whereas the one previously found in the documentation is incorrect. This update replaces the invalid command with the correct one.

linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed


The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 weeks ago

Welcome @amigueldiez!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 weeks ago

Hi @amigueldiez. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amigueldiez Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
minikube-bot commented 3 weeks ago

Can one of the admins verify this patch?

spowelljr commented 2 weeks ago

The previous command was invalid

minikube docker-env is a completely fine command, the command you replaced it with is just explicitly setting the profile flag, but if you don't supply the -p command it does -p minikube automatically (assuming you don't have a different profile set with minikube profile <profile>.