Addon headlamp: Update headlamp-k8s/headlamp image from v0.25.0 to v0.25.1

joaquimrocha commented 2 months ago

Upgrade Headlamp version to 0.25.1 cc: @joaquimrocha

k8s-ci-robot commented 2 months ago

Hi @joaquimrocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

minikube-bot commented 2 months ago

Can one of the admins verify this patch?

spowelljr commented 2 months ago

/ok-to-test

minikube-pr-bot commented 2 months ago

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19570) |
+----------------+----------+---------------------+
| minikube start | 52.0s    | 52.2s               |
| enable ingress | 15.8s    | 15.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 19570) ingress: 16.1s 15.6s 15.0s 16.1s 15.6s Times for minikube ingress: 16.0s 16.0s 15.6s 15.0s 16.6s Times for minikube start: 51.4s 53.3s 50.6s 50.6s 54.1s Times for minikube (PR 19570) start: 52.6s 48.8s 55.1s 52.9s 51.5s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19570) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 22.5s               |
| enable ingress | 12.9s    | 13.1s               |
+----------------+----------+---------------------+

Times for minikube start: 20.3s 25.6s 21.7s 20.9s 21.5s Times for minikube (PR 19570) start: 23.2s 20.5s 23.7s 23.6s 21.3s Times for minikube (PR 19570) ingress: 13.3s 12.3s 13.9s 13.8s 12.3s Times for minikube ingress: 12.8s 12.3s 13.3s 12.8s 13.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19570) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.5s               |
| enable ingress | 36.0s    | 37.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 19570) start: 23.3s 23.1s 23.8s 19.7s 22.3s Times for minikube start: 19.8s 22.8s 23.6s 20.7s 22.6s Times for minikube ingress: 32.3s 32.3s 38.8s 37.8s 38.8s Times for minikube (PR 19570) ingress: 38.8s 39.3s 38.8s 29.0s 39.3s

minikube-pr-bot commented 2 months ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
Docker_Linux_crio_arm64 (6 failed)	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup(gopogh)	0.00% (chart)
Docker_Linux_crio_arm64 (6 failed)	TestFunctional/parallel/TunnelCmd/serial/AccessDirect(gopogh)	0.00% (chart)
Docker_Linux_crio_arm64 (6 failed)	TestFunctional/parallel/PersistentVolumeClaim(gopogh)	0.67% (chart)

Besides the following environments also have failed tests:

Docker_Linux: 1 failed (gopogh)
Docker_Linux_containerd_arm64: 1 failed (gopogh)
KVM_Linux: 1 failed (gopogh)
QEMU_macOS: 98 failed (gopogh)
Docker_Cloud_Shell: 6 failed (gopogh)
Docker_Linux_crio: 3 failed (gopogh)
Docker_Linux_docker_arm64: 1 failed (gopogh)
Docker_macOS: 1 failed (gopogh)
none_Linux: 1 failed (gopogh)
KVM_Linux_crio: 30 failed (gopogh)

To see the flake rates of all tests by environment, click here.

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaquimrocha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [spowelljr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

spowelljr commented 2 months ago

Hi @joaquimrocha, every time I try to merge the PR I get the following, could you try rebasing and see if that helps, I'm able to merge other PRs fine.

joaquimrocha commented 2 months ago

Hi @spowelljr . I have been on vacation but I am back now. Let me see if there's anything I can do.

spowelljr commented 2 months ago

That fixed it, thanks!

minikube-pr-bot commented 2 months ago

kvm2 driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 19570) |
+-------------------+----------+---------------------+
| minikube start    | 47.0s    | 47.8s               |
| ⚠️  enable ingress | 15.7s    | 26.2s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 19570) start: 48.0s 49.5s 44.7s 47.6s 49.1s Times for minikube start: 47.0s 47.6s 47.6s 49.0s 43.6s Times for minikube ingress: 14.9s 19.0s 14.9s 14.9s 14.9s Times for minikube (PR 19570) ingress: 14.5s 14.4s 14.4s 13.9s 73.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19570) |
+----------------+----------+---------------------+
| minikube start | 20.8s    | 21.3s               |
| enable ingress | 11.8s    | 12.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 19570) start: 20.3s 23.5s 20.8s 21.3s 20.7s Times for minikube start: 20.1s 20.0s 23.8s 20.3s 19.9s Times for minikube ingress: 10.8s 12.7s 10.7s 12.7s 12.2s Times for minikube (PR 19570) ingress: 10.7s 12.7s 12.8s 12.8s 12.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19570) |
+----------------+----------+---------------------+
| minikube start | 20.7s    | 20.1s               |
| enable ingress | 27.4s    | 29.5s               |
+----------------+----------+---------------------+

Times for minikube start: 19.8s 18.5s 21.8s 23.4s 20.2s Times for minikube (PR 19570) start: 19.5s 19.5s 19.4s 19.8s 22.5s Times for minikube ingress: 28.7s 23.3s 23.2s 38.8s 23.2s Times for minikube (PR 19570) ingress: 39.3s 23.2s 23.3s 22.7s 38.7s

minikube-pr-bot commented 2 months ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
KVM_Linux (3 failed)	TestMultiControlPlane/serial/RestartClusterKeepsNodes(gopogh)	1.32% (chart)
KVM_Linux (3 failed)	TestMultiControlPlane/serial/DeleteSecondaryNode(gopogh)	1.32% (chart)

Besides the following environments also have failed tests:

Docker_Linux_containerd_arm64: 1 failed (gopogh)
Docker_Linux_crio_arm64: 3 failed (gopogh)
Hyper-V_Windows: 13 failed (gopogh)
Docker_Linux_crio: 3 failed (gopogh)
Docker_Linux_docker_arm64: 1 failed (gopogh)
none_Linux: 1 failed (gopogh)
Docker_Linux: 1 failed (gopogh)
KVM_Linux_crio: 30 failed (gopogh)
Hyperkit_macOS: 14 failed (gopogh)

To see the flake rates of all tests by environment, click here.

kubernetes / minikube

Addon headlamp: Update headlamp-k8s/headlamp image from v0.25.0 to v0.25.1 #19570