search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.5k stars 4.89k forks source link

Disallow using Docker Desktop 4.34.0 on macos #19576

Closed medyagh closed 2 months ago

medyagh commented 2 months ago

because https://github.com/docker/for-mac/issues/7412 https://github.com/docker/for-mac/issues/7411

after this PR

$ mk start -d docker
😄  minikube v1.34.0 on Darwin 14.6.1 (arm64)
✨  Using the docker driver based on user configuration

💣  Exiting due to PROVIDER_DOCKER_DESKTOP_VERSION_BAD: Docker Desktop 4.34.0 has a regression that prevents minikube from listing the containers
💡  Suggestion: Use a different Docker desktop version, more info at https://github.com/docker/for-mac/issues/7412
medyagh commented 2 months ago

Can you update the changelog to notify users about this issue

done

medyagh commented 2 months ago

/ok-to-test

minikube-pr-bot commented 2 months ago

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19576) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 51.2s               |
| enable ingress | 14.9s    | 15.1s               |
+----------------+----------+---------------------+
Times for minikube (PR 19576) start: 52.8s 50.5s 48.9s 52.5s 51.3s Times for minikube start: 49.2s 50.2s 50.0s 51.1s 53.9s Times for minikube ingress: 16.0s 14.5s 14.5s 15.0s 14.5s Times for minikube (PR 19576) ingress: 15.0s 14.5s 15.0s 16.0s 15.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19576) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 21.2s               |
| enable ingress | 11.3s    | 12.6s               |
+----------------+----------+---------------------+
Times for minikube (PR 19576) ingress: 12.8s 12.3s 12.3s 12.8s 12.8s Times for minikube ingress: 10.3s 11.3s 10.3s 12.3s 12.3s Times for minikube start: 23.6s 20.5s 24.3s 24.4s 22.9s Times for minikube (PR 19576) start: 20.6s 20.8s 21.7s 22.0s 20.7s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 19576) |
+-------------------+----------+---------------------+
| minikube start    | 20.6s    | 20.6s               |
| ⚠️  enable ingress | 32.5s    | 37.6s ⚠️             |
+-------------------+----------+---------------------+
Times for minikube ingress: 22.8s 38.8s 22.7s 38.8s 39.2s Times for minikube (PR 19576) ingress: 38.8s 38.8s 39.3s 32.3s 38.8s Times for minikube start: 19.5s 21.8s 22.3s 19.2s 20.0s Times for minikube (PR 19576) start: 19.7s 20.4s 20.1s 23.0s 19.6s
k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [medyagh,spowelljr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
minikube-pr-bot commented 2 months ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Windows (3 failed) TestAddons/parallel/Registry(gopogh) Unknown
Docker_Windows (3 failed) TestFunctional/parallel/License(gopogh) 0.00% (chart)
Docker_Linux_crio_arm64 (4 failed) TestFunctional/parallel/License(gopogh) 6.54% (chart)
Docker_Linux_containerd_arm64 (2 failed) TestFunctional/parallel/License(gopogh) 6.54% (chart)
none_Linux (2 failed) TestFunctional/parallel/License(gopogh) 6.90% (chart)
Docker_Linux_crio (4 failed) TestFunctional/parallel/License(gopogh) 6.58% (chart)
KVM_Linux (2 failed) TestFunctional/parallel/License(gopogh) 6.71% (chart)
Docker_Linux_docker_arm64 (2 failed) TestFunctional/parallel/License(gopogh) 6.54% (chart)
Docker_Linux (2 failed) TestFunctional/parallel/License(gopogh) 6.54% (chart)
Docker_Cloud_Shell (7 failed) TestFunctional/parallel/License(gopogh) 7.25% (chart)
Docker_Linux_containerd (1 failed) TestFunctional/parallel/License(gopogh) 6.58% (chart)
KVM_Linux_containerd (1 failed) TestFunctional/parallel/License(gopogh) 6.54% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.