search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.24k stars 4.87k forks source link

remove helm-tiller addon #19636

Closed tylerauerbeck closed 1 week ago

tylerauerbeck commented 2 weeks ago

This PR drops the helm-tiller add-on as it has been deprecated for quite some time.

fixes #19604

minikube-bot commented 2 weeks ago

Can one of the admins verify this patch?

k8s-ci-robot commented 2 weeks ago

Welcome @tylerauerbeck!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 weeks ago

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, tylerauerbeck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [medyagh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
medyagh commented 2 weeks ago

/ok-to-test

minikube-pr-bot commented 2 weeks ago

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19636) |
+----------------+----------+---------------------+
| minikube start | 48.0s    | 49.1s               |
| enable ingress | 16.0s    | 15.7s               |
+----------------+----------+---------------------+
Times for minikube ingress: 16.5s 16.1s 15.6s 15.0s 17.0s Times for minikube (PR 19636) ingress: 16.0s 14.6s 16.1s 16.0s 16.0s Times for minikube start: 47.1s 46.8s 51.0s 47.0s 48.2s Times for minikube (PR 19636) start: 50.2s 47.0s 48.7s 50.2s 49.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19636) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 22.5s               |
| enable ingress | 13.2s    | 13.5s               |
+----------------+----------+---------------------+
Times for minikube start: 24.7s 24.6s 24.2s 23.6s 21.2s Times for minikube (PR 19636) start: 24.3s 21.7s 24.4s 21.1s 21.1s Times for minikube ingress: 13.9s 13.3s 13.3s 13.3s 12.4s Times for minikube (PR 19636) ingress: 13.8s 13.3s 13.3s 13.3s 13.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19636) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.7s               |
| enable ingress | 26.5s    | 23.2s               |
+----------------+----------+---------------------+
Times for minikube start: 22.6s 20.5s 23.8s 19.8s 23.3s Times for minikube (PR 19636) start: 20.6s 23.5s 20.4s 20.7s 23.5s Times for minikube ingress: 22.8s 22.8s 39.8s 24.3s 22.8s Times for minikube (PR 19636) ingress: 23.8s 22.8s 23.8s 22.8s 22.8s
minikube-pr-bot commented 2 weeks ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.