search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.24k stars 4.87k forks source link

Addons registry: Update kube-registry-proxy from 0.0.6 to 0.0.7 #19711

Closed spowelljr closed 21 hours ago

spowelljr commented 1 day ago

Updating the kube-registry-proxy from 0.0.6 to 0.0.7

To see changes to the Dockerfile see: https://github.com/spowelljr/kube-registry-proxy/commit/a153665dcfafd852f519281b1b8456a25885d1a3

Updated the base image from nginx:1.25.4 to nginx:1.27.1-alpine

This resolves several CVEs

0.0.6:

65 vulnerabilities found in 28 packages
  UNSPECIFIED  5   
  LOW          42  
  MEDIUM       7   
  HIGH         6   
  CRITICAL     5

0.0.7:

1 vulnerability found in 1 package
  LOW       0  
  MEDIUM    1  
  HIGH      0  
  CRITICAL  0

This also resulted in a 71.5% reduction in image size

0.0.6: 192.02 MB 0.0.7: 54.66 MB

Confirmed the new image works:

$ kubectl run --rm registry-test --restart=Never --image=gcr.io/k8s-minikube/busybox -it -- sh -c "wget --spider -S http://registry.kube-system.svc.cluster.local"
Connecting to registry.kube-system.svc.cluster.local (10.96.254.17:80)
  HTTP/1.1 200 OK
  Cache-Control: no-cache
  Date: Thu, 26 Sep 2024 23:54:00 GMT
  Content-Length: 0
  Connection: close

remote file exists
pod "registry-test" deleted
spowelljr commented 1 day ago

/ok-to-test

minikube-pr-bot commented 1 day ago

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19711) |
+----------------+----------+---------------------+
| minikube start | 48.5s    | 47.9s               |
| enable ingress | 15.0s    | 15.0s               |
+----------------+----------+---------------------+
Times for minikube start: 46.0s 50.5s 46.6s 50.7s 48.7s Times for minikube (PR 19711) start: 47.0s 47.8s 49.2s 48.7s 47.2s Times for minikube ingress: 15.1s 15.0s 15.0s 14.5s 15.5s Times for minikube (PR 19711) ingress: 15.5s 15.0s 14.5s 15.0s 15.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19711) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 22.2s               |
| enable ingress | 12.3s    | 12.8s               |
+----------------+----------+---------------------+
Times for minikube start: 24.1s 24.3s 23.7s 21.5s 25.2s Times for minikube (PR 19711) start: 20.2s 21.7s 23.7s 21.2s 24.2s Times for minikube ingress: 12.8s 13.3s 12.8s 11.3s 11.3s Times for minikube (PR 19711) ingress: 13.9s 12.8s 13.3s 10.8s 13.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19711) |
+----------------+----------+---------------------+
| minikube start | 21.2s    | 20.6s               |
| enable ingress | 30.4s    | 27.1s               |
+----------------+----------+---------------------+
Times for minikube start: 23.1s 23.1s 19.8s 20.5s 19.5s Times for minikube (PR 19711) start: 19.5s 19.5s 22.5s 19.8s 21.8s Times for minikube ingress: 38.8s 29.0s 22.8s 22.8s 38.8s Times for minikube (PR 19711) ingress: 28.3s 22.8s 22.8s 22.8s 38.8s
minikube-pr-bot commented 1 day ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio_arm64 (4 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) 5.17% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

medyagh commented 21 hours ago

/lgtm

k8s-ci-robot commented 21 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [medyagh,spowelljr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment