search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.5k stars 4.89k forks source link

testing: Add defer to disable addon to start of each addon test #19715

Closed spowelljr closed 1 month ago

spowelljr commented 1 month ago

https://github.com/kubernetes/minikube/issues/19714

Add defer to disable addon to start of each addon test. In relation to https://github.com/kubernetes/minikube/issues/19714, this will prevent GCP-Auth addon mock issue from affecting the registry test.

This PR should fix the registry test for all environments.

spowelljr commented 1 month ago

/ok-to-test

minikube-pr-bot commented 1 month ago

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19715) |
+----------------+----------+---------------------+
| minikube start | 50.4s    | 50.5s               |
| enable ingress | 16.7s    | 15.6s               |
+----------------+----------+---------------------+
Times for minikube ingress: 17.1s 16.1s 15.6s 19.1s 15.5s Times for minikube (PR 19715) ingress: 15.6s 15.0s 15.5s 15.6s 16.1s Times for minikube start: 49.6s 50.3s 51.2s 51.6s 49.4s Times for minikube (PR 19715) start: 49.4s 49.5s 50.3s 51.9s 51.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19715) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 22.7s               |
| enable ingress | 13.0s    | 12.5s               |
+----------------+----------+---------------------+
Times for minikube ingress: 12.3s 12.8s 13.3s 13.9s 12.8s Times for minikube (PR 19715) ingress: 13.8s 12.8s 10.8s 12.3s 12.8s Times for minikube start: 23.9s 24.2s 20.8s 23.4s 24.3s Times for minikube (PR 19715) start: 23.3s 20.7s 23.5s 21.4s 24.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19715) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 21.4s               |
| enable ingress | 29.3s    | 24.2s               |
+----------------+----------+---------------------+
Times for minikube start: 23.4s 22.3s 23.3s 23.0s 22.6s Times for minikube (PR 19715) start: 22.5s 19.2s 22.4s 20.0s 22.8s Times for minikube ingress: 22.8s 22.8s 22.8s 38.8s 39.3s Times for minikube (PR 19715) ingress: 29.3s 22.8s 22.8s 23.3s 22.8s
minikube-pr-bot commented 1 month ago

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
KVM_Linux (1 failed) TestMultiNode/serial/RestartMultiNode(gopogh) 0.60% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [medyagh,spowelljr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment