search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.5k stars 4.89k forks source link

translations: Fix translation on wrong line #19718

Closed spowelljr closed 1 month ago

spowelljr commented 1 month ago
uos-ljtian commented 1 month ago

There was a problem with the content I submitted. I'm very sorry. I will check it again next time.

prezha commented 1 month ago

no worries @uos-ljtian and thank you for the contribution!

you can use eg go test ./pkg/minikube/translate -run TestTranslationFilesValid -v for local testing

is this fix correct, please?

uos-ljtian commented 1 month ago

The modification is correct

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/minikube/blob/master/OWNERS)~~ [prezha,spowelljr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment