kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.34k stars 4.88k forks source link

Seamless integration of docker cli, docker-machine, minikube and kubernetes #2681

Closed zbbfufu closed 6 years ago

zbbfufu commented 6 years ago

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Please provide the following details:

Environment:

What happened: When I start using some minikube profile/instance, in order to get consistency between docker cli, docker-machine, kubernetes and minikube, I have to perform some hack and run multiple commands.

What you expected to happen: Seamless configuration of all these tools on minikube profile change.

r2d4 commented 6 years ago

This is fair. Not all commands respect the config profile, but they should.

zbbfufu commented 6 years ago

Thanks @r2d4. What do you suggest to improve my setup ? Do you see a way to implement this feature ? I could make a PR with some help (I never wrote Go code but I could learn it quite easily).

afbjorklund commented 6 years ago

Sounds that what you are after is some kind of "Kubernetes Toolbox", that will bundle several items ? Similar to that "Docker Toolbox" that bundled machine and some other friends for a all-in-one thing.

Not sure if it should be the default though. It's quite common/normal to have a separate Docker. Don't think your commands look so much like "hacks", look more like normal configuration to me ?

Shortcuts/documentation can always be improved, though.

BTW; where does the docker cli come from, with your setup ?

gbraad commented 6 years ago

Some improvements are of course possible, but automatically setting the docker variables in the shell (pointing to the VM) would in my opinion not be wanted, as it has the effect of overwriting a possible local Docker instance on Linux, or hiding the Docker for Windows/macOS. I'd still keep this a user initiated action.

However, maybe allowing an easier way to integrate with docker-machine might be a possibility... however, what is the motivation for this (besides the 'profile')? which commands or actions are you missing?

afbjorklund commented 6 years ago

It's also not guaranteed that Minikube will use, or be compatible with, Docker (and Docker Machine)...

With the integration of cri-o and the maintenance mode of machine, things could change in the future.

gbraad commented 6 years ago

Off-topic: FYI, @afbjorklund we have forked machine as machine-drivers/machine, and integration of Cri-o is a possiblity we consider. you can file an issue for this... as we haven't done this yet.

afbjorklund commented 6 years ago

@gbraad : cri-o and crictl have been updated (to v1.10.0) and merged, so that's already available

gbraad commented 6 years ago

Off-topic: @afbjorklund have kept an eye on this. We are also working on getting this for CentOS.

bersace commented 6 years ago

Well, if not docker CLI then podman ;-)

gbraad commented 6 years ago

Off-topic:: Never got podman to work: https://gist.github.com/gbraad/be3090bff1264e15ad275ddaab9acacc. But would like when minikube ISO and the Minishift ISO can run this OOTB.

fejta-bot commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

zbbfufu commented 6 years ago

Hi,

Thanks for all your advices. Since the creation of this issue I work a lot more with Minikube but less with docker-machine instances, and I recognize that I don't use my special setup anymore.

I think I was in a edge-case situation. Having some kind of synchronization/compatibility between docker-machine and minikube could be nice for people frequently using both, but it's not a common use-case.

Sorry for the inconvenience.

gbraad commented 6 years ago

No worries. It has been valuable anyway. I do use Minishift with our generic driver to ssh quickly into remote docker/container hosts... so i understand the question.

however, this is not a common use-case

On Thu, Jul 12, 2018 at 6:07 PM, Julien Furgerot notifications@github.com wrote:

Hi,

Thanks for all your advices. Since the creation of this issue I work a lot more with Minikube but less with docker-machine instances, and I recognize that I don't use my special setup anymore.

I think I was in a edge-case situation. Having some kind of synchronization/compatibility between docker-machine and minikube could be nice for people frequently using both, but it's not a common use-case.

Sorry for the inconvenience.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/minikube/issues/2681#issuecomment-404461552, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAHZpHU08vWMnm58t77ACVXn6hykyT-ks5uFx_XgaJpZM4TJE9t .

--

Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]