search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.33k stars 4.88k forks source link

minikube should not start knfsd by default #3143

Open jtlayton opened 6 years ago

jtlayton commented 6 years ago

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Please provide the following details:

Environment:

Minikube version (use minikube version): v0.28.2

On startup, minikube starts up knfsd (via the nfs-server.service under systemd), even though it serves no exports. This makes it somewhat useless -- it should not start the nfs server unless it has something to serve:

● nfs-server.service - NFS server and services
   Loaded: loaded (/usr/lib/systemd/system/nfs-server.service; enabled; vendor preset: enabled)
   Active: inactive (dead) since Thu 2018-09-20 13:34:48 UTC; 7min ago
  Process: 2886 ExecStopPost=/usr/sbin/exportfs -f (code=exited, status=0/SUCCESS)
  Process: 2883 ExecStopPost=/usr/sbin/exportfs -au (code=exited, status=0/SUCCESS)
  Process: 2880 ExecStop=/usr/sbin/rpc.nfsd 0 (code=exited, status=0/SUCCESS)
 Main PID: 1781 (code=exited, status=0/SUCCESS)

Sep 20 12:06:54 minikube systemd[1]: Starting NFS server and services...
Sep 20 12:06:54 minikube systemd[1]: Started NFS server and services.
Sep 20 13:34:48 minikube systemd[1]: Stopping NFS server and services...
Sep 20 13:34:48 minikube systemd[1]: Stopped NFS server and services.

When constructing the ISO, could we add in a call to "systemctl disable nfs-server" to ensure that it's not started by default?

tstromberg commented 6 years ago

First, long time no see, Jeff!

Second, this request seems entirely reasonable. Thanks for the suggestion!

jtlayton commented 6 years ago

Hah, yes! Hope you're doing well, Thomas!

FWIW, my main interest here is that I'm working on a clustered NFS server that runs under k8s, and this makes it hard to use the standard NFS port as a NodePort.

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

afbjorklund commented 5 years ago

The buildroot configuration for this is NFS_UTILS_INSTALL_INIT_SYSTEMD

    ln -fs ../../../../usr/lib/systemd/system/nfs-server.service \
        $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/nfs-server.service
nanikjava commented 5 years ago

@afbjorklund @tstromberg any decision whether we want this service to be disabled by default ?

sharifelgamal commented 4 years ago

Yeah this seems reasonable honestly.