Closed josedonizetti closed 5 years ago
/assign @josedonizetti
it seems to be glog not playing nice ! (maybe we should migrate to klog like kubernetes soon)
seems to be related to istio/istio#2127 seems like it has been fixed in this PR spf13/cobra#75
I recommend bumping up our cobra to the newer version
Can this be fixed with the "initflag" hack, or do we need to revert k8s ?
Otherwise this will be blocking v1.3.0, can't release minikube like this...
Yay for global variables!
https://github.com/golang/glog/commit/65d674618f712aa808a7d0104131b9206fc3d5ad
@afbjorklund I'm doing as many tests as possible today on this. Hopefully, we can release it without any problem, I'll write it back here if I think it's a go or not in a few hours. Okay?
Oddly enough, I'm seeing this on integration tests, at least on Windows:
14:52:03 ! "minikube" cluster does not exist
14:52:03 * The "minikube" cluster has been deleted.
14:52:04 ERROR: logging before flag.Parse: I0806 14:50:38.565508 8348 vm_assets.go:203] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
14:52:04 ERROR: logging before flag.Parse: I0806 14:50:38.565508 8348 vm_assets.go:203] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
14:52:04 ERROR: logging before flag.Parse: I0806 14:50:38.565508 8348 vm_assets.go:203] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
14:52:04 ERROR: logging before flag.Parse: I0806 14:50:38.565508 8348 vm_assets.go:203]
Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
14:52:04 ERROR: logging before flag.Parse: I0806 14:50:38.565508 8348 vm_assets.go:203] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
14:52:04 ERROR: logging before flag.Parse: I0806 14:50:38.565508 8348 vm_assets.go:203]
Fixed.
After the k8s bump to 1.15.0, I started to see:
This was happening to k8s repo too. https://github.com/kubernetes/kubernetes/issues/17162