Integration Scripts: install consistent version of tools in integration tests

kubernetes / minikube

Run Kubernetes locally

https://minikube.sigs.k8s.io/

Apache License 2.0

28.83k stars 4.82k forks source link

Integration Scripts: install consistent version of tools in integration tests #4914

Closed medyagh closed 3 years ago

medyagh commented 4 years ago

We need to have same version for the following tools for integration tests:

golang
kubectl version
virtualbox
docker
libvirt

sharifelgamal commented 4 years ago

Do we know what specific version of these we want to pin to?

afbjorklund commented 4 years ago

I think we have pinned go version to 1.12.7 in most places soon, maybe not go test though.

Most likely we want to use the very same version of kubectl client as we have on the server ?

medyagh commented 4 years ago

@afbjorklund this ticket is targeted toward integration tests tools not building ones.

@sharifelgamal here is more context:

There should be shell scripts that each job calls to install tools required, for example : the file https://github.com/kubernetes/minikube/blob/master/hack/jenkins/linux_integration_tests_virtualbox.sh should call a script call linux_integration_tests_virtualbox.sh

that checks if that specific version of virtualbox exists if not, install them.

same other job types:

linux_integration_tests_kvm.sh
linux_integration_tests_none.sh
linux_integration_tests_virtualbox.sh
osx_integration_tests_hyperkit.sh
osx_integration_tests_virtualbox.sh

tstromberg commented 4 years ago

Add crictl to this list.

tstromberg commented 4 years ago

This still exists.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/minikube/issues/4914#issuecomment-695354555): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.