search

kubernetes / minikube

Run Kubernetes locally
https://minikube.sigs.k8s.io/
Apache License 2.0
29.1k stars 4.86k forks source link

`delete` should omit `docker` commands for non-docker drivers #7960

Open afbjorklund opened 4 years ago

afbjorklund commented 4 years ago

Currently we always run the docker and podman volume cleanup commands.

Especially the docker volume is annoying, because it is so very slow to run...

Should try to only run commands relevant to the profiles and machines deleted ?

Normally the volume will be deleted with the container, using the rm -v command.

afbjorklund commented 4 years ago

It takes me 30 seconds to run "minikube delete", even when there are no clusters!

$ minikube status
🤷  There is no local cluster named "minikube"
👉  To fix this, run: "minikube start"
$ time minikube delete
🙄  "minikube" profile does not exist, trying anyways.
💀  Removed all traces of the "minikube" cluster.

real    0m30.533s
user    0m0.420s
sys 0m0.156s

The reason for this is that each docker volume takes 15 seconds to run.

EDIT: Found the culprit, I had an old plugin installed (that was timing out)

afbjorklund commented 4 years ago

Also it seems like the podman version is currently broken:

[prune volume by label name.minikube.sigs.k8s.io=minikube: sudo podman volume prune -f --filter label=name.minikube.sigs.k8s.io=minikube: exit status 125
stdout:

stderr:
Error: unknown flag: --filter
]

"volume ls" does have the flag, but "volume prune" does not.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten