kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.95k stars 627 forks source link

Add disk and memory percent_used #825

Closed kasbert closed 9 months ago

kasbert commented 1 year ago

Add percentage of disk and memory usage based on the values in disk/bytes_used and memory/bytes_used .

Includes stackdriver configuration with "custom.googleapis.com" as it is not possible to add metrics to "compute.googleapis.com".

Previous PR 824 had a wrong committer.

k8s-ci-robot commented 1 year ago

Hi @kasbert. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hakman commented 1 year ago

/ok-to-test

hakman commented 1 year ago

/lgtm /cc @MartinForReal @mmiranda96 /assign @dchen1107 @vteratipally

MartinForReal commented 12 months ago

/lgtm

kasbert commented 11 months ago

/retest-required

kasbert commented 11 months ago

/retest

hakman commented 11 months ago

@kasbert Seems unrelated:

Oct 31 04:03:58 systemd[1]: Started Node problem detector.
 node-problem-detector[723]: /home/kubernetes/bin/node-problem-detector: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /home/kubernetes/bin/node-problem-detector)
Oct 31 04:03:58 systemd[1]: node-problem-detector.service: Main process exited, code=exited, status=1/FAILURE
Oct 31 04:03:58 systemd[1]: node-problem-detector.service: Failed with result 'exit-code'.
Oct 31 04:04:08 systemd[1]: node-problem-detector.service: Scheduled restart job, restart counter is at 1.
Oct 31 04:04:08 systemd[1]: Stopped Node problem detector.
hakman commented 11 months ago

/retest

vteratipally commented 9 months ago

/lgtm /approve

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, kasbert, MartinForReal, mmiranda96, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [vteratipally] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment