search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.85k stars 616 forks source link

fix: fix pprof by using DefaultServeMux #828

Closed j4ckstraw closed 7 months ago

j4ckstraw commented 9 months ago

replace http.NewServeMux with http.DefaultServeMux

see https://pkg.go.dev/net/http/pprof

By default, all the profiles listed in runtime/pprof.Profile are available (via Handler), in addition to the Cmdline, Profile, Symbol, and Trace profiles defined in this package. If you are not using DefaultServeMux, you will have to register handlers with the mux you are using.

k8s-ci-robot commented 9 months ago

Welcome @j4ckstraw!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 9 months ago

Hi @j4ckstraw. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
j4ckstraw commented 9 months ago

/ok-to-test

k8s-ci-robot commented 9 months ago

@j4ckstraw: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubernetes/node-problem-detector/pull/828#issuecomment-1751663354): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MartinForReal commented 9 months ago

/ok-to-test

MartinForReal commented 9 months ago

Do you think if it is a good idea to register the pprof handler with the new mux? @j4ckstraw

j4ckstraw commented 9 months ago

Do you think if it is a good idea to register the pprof handler with the new mux? @j4ckstraw

I think default mux is enough.

  1. Default mux is simple.
  2. Maybe default mux have known performance problem, while this is only for debug, performance is not a primary consideration.
MartinForReal commented 9 months ago

It makes sense. But maybe it is better to explicitly define the required handler. And it will be less likely to be broken by package update .

j4ckstraw commented 9 months ago

It makes sense. But maybe it is better to explicitly define the required handler. And it will be less likely to be broken by package update .

OK, I'll file a new patch.

MartinForReal commented 9 months ago

/lgtm

MartinForReal commented 9 months ago

/assign @hakman @mmiranda96 @vteratipally

hakman commented 9 months ago

/lgtm

j4ckstraw commented 9 months ago

ping~

MartinForReal commented 9 months ago

@vteratipally Any advice is appreciated!

j4ckstraw commented 7 months ago

ping again~

vteratipally commented 7 months ago

/lgtm /approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, j4ckstraw, MartinForReal, mmiranda96, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [vteratipally] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment