search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.85k stars 616 forks source link

bump k8s.io to 0.28.4 #838

Closed MartinForReal closed 7 months ago

MartinForReal commented 8 months ago

bump k8s.io to 0.28.4

MartinForReal commented 8 months ago

/assign @vteratipally

MartinForReal commented 8 months ago

/assign @hakman

MartinForReal commented 8 months ago

/assign @vteratipally

hakman commented 8 months ago

One more thing @MartinForReal, I don't think we want to add the vendor folder for the test dir. Could you remove?

hakman commented 8 months ago

/lgtm /assign @vteratipally

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hakman, MartinForReal Once this PR has been reviewed and has the lgtm label, please ask for approval from vteratipally. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MartinForReal commented 7 months ago

hi @vteratipally Do you have any advice on this? Thanks!

vteratipally commented 7 months ago

updated to v0.29.0 /close

k8s-ci-robot commented 7 months ago

@vteratipally: Closed this PR.

In response to [this](https://github.com/kubernetes/node-problem-detector/pull/838#issuecomment-1858132941): >updated to v0.29.0 >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.