search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.85k stars 616 forks source link

What is up with the v0.8.15 tag? #851

Closed elchenberg closed 3 months ago

elchenberg commented 6 months ago

There is a two weeks old v0.8.15 tag. In contrast to all the other (recent) tags it is not a verified commit and it is not a release. Is it safe to use anyway?

hakman commented 6 months ago

Is it safe to use anyway?

Yes. 😄

stafot commented 6 months ago

And actually fixes an arm support problem which previous tag has.

hakman commented 6 months ago

And actually fixes an arm support problem which previous tag has.

And many security related issues.

disconn3ct commented 6 months ago

Security issues such as......?

hakman commented 6 months ago

Newer base image, newer dependencies, newer Go. You can try running a container image scanner on .13, .14 and .15.

disconn3ct commented 6 months ago

You can try running a container image scanner on .13, .14 and .15.

Are you suggesting that users need to reverse-engineer your release notes?

chotiwat commented 5 months ago

It's missing the log-counter binary https://github.com/kubernetes/node-problem-detector/issues/854

grzesrap commented 5 months ago

when enable network-problem-monitor.json i see error: Failed to unmarshal configuration file "/config/network-problem-monitor.json": json: cannot unmarshal number into Go struct field MonitorConfig.pluginConfig of type string

when enable /config/system-stats-monitor.json i see error: No create function found for plugin ""

only /config/kernel-monitor.json, /config/docker-monitor.json and /config/systemd-monitor.json works for me k8s version: 1.21 image: registry.k8s.io/node-problem-detector/node-problem-detector:v0.8.15

Please check monitors:

wangzhen127 commented 3 months ago

/close

k/k is using NPD v0.8.16 already and there is a plan to bump to v0.8.18 after code freeze. You can try the new versions. Feel free to file new issues if the new version does not work.

k8s-ci-robot commented 3 months ago

@wangzhen127: Closing this issue.

In response to [this](https://github.com/kubernetes/node-problem-detector/issues/851#issuecomment-2040283165): >/close > >k/k is using NPD v0.8.16 already and there is a plan to bump to v0.8.18 after code freeze. You can try the new versions. Feel free to file new issues if the new version does not work. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.