fix bug in skip_initial_status

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.

Apache License 2.0

2.85k stars 616 forks source link

fix bug in skip_initial_status #856

Closed levaspb closed 3 months ago

levaspb commented 5 months ago

I have found a bug in in the merged PR that introduced the skip_initial_status feature. This bug unjustly leaves conditions stagnant when this feature is enabled in a custom plugin configuration. The root cause is that the conditions for the plugin aren't properly initialized. The PR implies that when skip_initial_status is set, the initialConditions function is called. As a result, custom plugins with skip_initial_status work correctly.

linux-foundation-easycla[bot] commented 5 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: levaspb / name: leva_spb (f24dbb13f798066e9878109426f973d4ecbb4638)

k8s-ci-robot commented 5 months ago

Welcome @levaspb!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 5 months ago

Hi @levaspb. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

vteratipally commented 5 months ago

/ok-to-test

hakman commented 4 months ago

/lgtm /assign @vteratipally

levaspb commented 4 months ago

/assign @sjenning

levaspb commented 4 months ago

ping @sjenning for approval

levaspb commented 4 months ago

/retest

levaspb commented 4 months ago

all tests successfully passed @sjenning please review

hakman commented 3 months ago

/cc @wangzhen127

vteratipally commented 3 months ago

/lgtm /approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, levaspb, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [vteratipally] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

a7i commented 5 days ago

amazing! tested this and it looks good 👍🏼