search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.85k stars 616 forks source link

Get Node object from APIServer cache #864

Closed linxiulei closed 3 months ago

linxiulei commented 5 months ago

The risk is pretty low given the returned Node object isn't actually used anywhere - two places invoking GetNode()

  1. k8s_exporter calls it to check if readiness but the returned node object is discarded right away
  2. GetConditions, which is not referenced anywhere
hakman commented 4 months ago

Thanks @linxiulei! /lgtm

hakman commented 3 months ago

/cc @wangzhen127

hakman commented 3 months ago

/test all

vteratipally commented 3 months ago

/lgtm /approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, linxiulei, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [vteratipally] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hakman commented 3 months ago

/retest