search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.85k stars 616 forks source link

Release v0.8.16 #869

Closed hakman closed 4 months ago

hakman commented 4 months ago

This should address the missing log-counter binary.

/cc @vteratipally @pacoxu @MartinForReal /assign @vteratipally

pacoxu commented 4 months ago

I triggered a test in Kuberentes CI https://github.com/kubernetes/kubernetes/pull/123550.

hakman commented 4 months ago

/hold for the test results

pacoxu commented 4 months ago

The test passed for NPD: flake for https://storage.googleapis.com/k8s-triage/index.html?test=Networking%20Granular%20Checks%3A%20Services%20should%20update%20endpoints%3A%20http.

pacoxu commented 4 months ago

/lgtm /unhold

hakman commented 4 months ago

The test passed for NPD: flake for https://storage.googleapis.com/k8s-triage/index.html?test=Networking%20Granular%20Checks%3A%20Services%20should%20update%20endpoints%3A%20http.

@pacoxu Test failed on 1 unrelated test. I think we are good to go. /unhold

MartinForReal commented 4 months ago

/lgtm

hakman commented 4 months ago

/cc @mrunalp

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, MartinForReal, mrunalp, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [mrunalp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vteratipally commented 4 months ago

could you please draft a release notes in one of the comments, it would be useful for all us. It is hard to track the changes after the release.

hakman commented 4 months ago

@vteratipally It is pretty hard to draft such release notes. The release trigger drafts it from the PR titles and depends on how good the titles are.