search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.85k stars 616 forks source link

Add hakman to the approvers list #870

Closed hakman closed 2 weeks ago

hakman commented 4 months ago

This should allow me to create releases.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hakman Once this PR has been reviewed and has the lgtm label, please assign vteratipally for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hakman commented 4 months ago

/cc @vteratipally /assign @vteratipally

JohnRusk commented 4 months ago

cc @derekwaynecarr , @wangzhen127 In case you can approve. My team is keen to get this release :-)

vteratipally commented 4 months ago

/cc @dchen1107

Could you please share the contribution details based on the approver policy. https://github.com/kubernetes/community/blob/master/community-membership.md

JohnRusk commented 4 months ago

@vteratipally The immediate need is for the generation of the 0.8.16 release, to fix CVEs and (I believe) at least one other issue. @hakman has completed the PR and the tag is applied, but he doesn't currently have permission to make an official release. If you think this request here to add him to the approvers list may be delayed or not approved, would it be possible for your yourself to generate the Release, as you did for the previous one.
Further discussion, if needed, is here https://kubernetes.slack.com/archives/CJA25LM6D/p1709062180808009

wangzhen127 commented 4 months ago

I haven't worked on NPD for the past few years. But I am starting to pick it up again recently. If the request is to make a new release, I can do that this time. I will sync up with @vteratipally on it.

Regarding the approvers, since I lack the knowledge on NPD work progress in recent years, I will defer it to @vteratipally.

JohnRusk commented 4 months ago

Thanks @wangzhen127 . Yes, that is the request. To make a new release based on the 0.8.16 tag that @hakman has already created.

wangzhen127 commented 4 months ago

OK. I will likely be able to make the 0.8.16 release early next week. Does that sound good?

vteratipally commented 4 months ago

Yes, we will be creating a new release early next week. Hope that should be fine.

JohnRusk commented 4 months ago

Thanks @wangzhen127 and @vteratipally. Before you cut that release, can you please take a look at this issue which I just logged: #871. We are seeing some brand new CVEs in the docker image that @hakman made a couple of days ago. Can these new CVEs be fixed, with the fixes included in the new release? They are reported as "HIGH" priority by our scanner.

If those fixes can be included in a release early next week, that would be great. Thanks.

vteratipally commented 4 months ago

Yes sure, we can fix them

hakman commented 4 months ago

@JohnRusk I understand the need for a new release. Thank you for your support, but I would like to keep this issue about adding myself to the approvers list.

@vteratipally I understand you have concerns about this PR. Would you mind contacting me in private and discussing them? Thanks!

vteratipally commented 4 months ago

@JohnRusk I understand the need for a new release. Thank you for your support, but I would like to keep this issue about adding myself to the approvers list.

@vteratipally I understand you have concerns about this PR. Would you mind contacting me in private and discussing them? Thanks!

Yes sure. We could set up some meeting.

hakman commented 4 months ago

Yes sure. We could set up some meeting.

Sure, please ping me in Slack and we can find some time that suits us both.

k8s-ci-robot commented 4 months ago

@hakman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags 704e03dc09ecf319eb3cb698a33fa1f8c76ec2cd link true /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags
pull-npd-e2e-kubernetes-gce-ubuntu 704e03dc09ecf319eb3cb698a33fa1f8c76ec2cd link true /test pull-npd-e2e-kubernetes-gce-ubuntu
pull-npd-e2e-kubernetes-gce-gci 704e03dc09ecf319eb3cb698a33fa1f8c76ec2cd link true /test pull-npd-e2e-kubernetes-gce-gci
pull-npd-e2e-kubernetes-gce-gci-custom-flags 704e03dc09ecf319eb3cb698a33fa1f8c76ec2cd link true /test pull-npd-e2e-kubernetes-gce-gci-custom-flags

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten