search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.83k stars 615 forks source link

Revert "Bump NPD versions to v0.8.17" #881

Closed wangzhen127 closed 4 months ago

wangzhen127 commented 4 months ago

Reverts kubernetes/node-problem-detector#879

Several CI tests fail due to this PR.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [wangzhen127] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wangzhen127 commented 4 months ago

/test pull-npd-e2e-kubernetes-gce-gci /test pull-npd-e2e-kubernetes-gce-gci-custom-flags /test pull-npd-e2e-kubernetes-gce-ubuntu /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags

wangzhen127 commented 4 months ago

/hold

Let me investigate more. May also be due to removing push-tar.

wangzhen127 commented 4 months ago

Looks like we cannot trigger pull-npd-e2e-kubernetes-gce-* presubmit tests here in NPD repo.

wangzhen127 commented 4 months ago

Figured it out. It is due to removing push-tar. We call make push in https://github.com/kubernetes/node-problem-detector/blob/master/test/build.sh#L141. I forgot to handle it. Abandoning this revert.