search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.83k stars 615 forks source link

Revert "Remove push-tar" #882

Closed wangzhen127 closed 4 months ago

wangzhen127 commented 4 months ago

Reverts kubernetes/node-problem-detector#880

Several CI tests fail due to this PR.

We should handle make push in the build script https://github.com/kubernetes/node-problem-detector/blob/master/test/build.sh#L141. Reverting this PR first. Will upload another PR with the right fix later.

Ref issue: https://github.com/kubernetes/node-problem-detector/issues/874

wangzhen127 commented 4 months ago

/assign @hakman

wangzhen127 commented 4 months ago

/test pull-npd-e2e-kubernetes-gce-gci

wangzhen127 commented 4 months ago

Looks like the presubmit pull-npd-e2e-kubernetes-gce-gci is actually triggered. It does not show up in the summary in the PR. We can see it here: https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-npd-e2e-kubernetes-gce-gci

wangzhen127 commented 4 months ago

pull-npd-e2e-kubernetes-gce-gci passed at https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/node-problem-detector/882/pull-npd-e2e-kubernetes-gce-gci/1766915906216136704

wangzhen127 commented 4 months ago

/test pull-npd-e2e-kubernetes-gce-gci-custom-flags /test pull-npd-e2e-kubernetes-gce-ubuntu /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags

hakman commented 4 months ago

/lgtm

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [wangzhen127] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment