search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
2.83k stars 615 forks source link

Add make release #883

Closed wangzhen127 closed 4 months ago

wangzhen127 commented 4 months ago

Adds a make release command for releasing new NPD version. It stops pushing the tar files to gs://kubernetes-release, because no one has write permission to the GCS bucket any more. We haven't pushed NPD tar files to that GCS bucket after v0.8.10. k/k has been using NPD v0.8.13+ since 1.29. NPD release should just include the tar files in the release note.

Ref issue: https://github.com/kubernetes/node-problem-detector/issues/874

hakman commented 4 months ago

/lgtm /hold in case you want a second opinion (feel free to /unhold at any time)

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [wangzhen127] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wangzhen127 commented 4 months ago

/unhold

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/directory/pull-npd-e2e-kubernetes-gce-gci/1767044854166065152 passed.