search

kubernetes / node-problem-detector

This is a place for various problem detectors running on the Kubernetes nodes.
Apache License 2.0
3.02k stars 633 forks source link

chore: qps flag: use float32 instead of float64 #983

Closed googs1025 closed 3 weeks ago

googs1025 commented 3 weeks ago

/kind cleanup

googs1025 commented 3 weeks ago

/assign @andyxning sorry for this..... Awkward... I made a small mistake, using fs has float32 methods... FYI: https://github.com/kubernetes/node-problem-detector/pull/980#discussion_r1819982150

andyxning commented 3 weeks ago

/lgtm /approve

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, googs1025

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/node-problem-detector/blob/master/OWNERS)~~ [andyxning] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment