search

kubernetes / org

Meta configuration for Kubernetes Github Org
Apache License 2.0
244 stars 693 forks source link

Move Kui repo to kubernetes-sigs #2461

Closed paulcastro closed 3 years ago

paulcastro commented 3 years ago

New Repo, Staging Repo, or migrate existing

Change ownership of existing repo from github.com/IBM

Requested name for new repository

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

If not a staging repo, who should have write access

If not a staging repo, who should be listed as approvers in OWNERS

If not a staging repo, who should be listed in SECURITY_CONTACTS

What should the repo description be

A hybrid command-line/UI development experience for cloud-native development

What SIG and subproject does this fall under in sigs.yaml

this is a subproject for sig-cli called Kui

Approvals

The sig-cli already tracks kui as a subproject as described in this KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/2257-kui

Additional context for request

/cc @soltysh @starpit

nikhita commented 3 years ago

/sig cli

/assign @soltysh @eddiezane @pwittrock for approval

soltysh commented 3 years ago

:+1: from my end, I'm positive that other leads are on -board since this was discussed during sig-cli multiple times in the past.

nikhita commented 3 years ago

@soltysh thanks for the ack!

@paulcastro since the repo needs to be migrated, can you ensure that the repo meets the requirements listed here - https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md#rules-for-donated-repositories?

Once that's done, please ping me here again and I can help with the migration. :)

pwittrock commented 3 years ago

+1

starpit commented 3 years ago

@nikhita Thanks for the help! I think we have all of the rules engaged with the following exceptions:

1) the CLA bot is set up, but we are still waiting for @thelinuxfoundation to accept the user invitation; this is needed to fully enable the bot

2) prow: is my understanding correct that we will need to find a cluster to host this? or is their provision for piggybacking multiple projects onto a single prow?

nikhita commented 3 years ago

the CLA bot is set up, but we are still waiting for @thelinuxfoundation to accept the user invitation; this is needed to fully enable the bot

@starpit -- the linuxfoundation bot will not accept the invitation. Once the repo is migrated over, CLA checks will automatically be enabled on all PRs.

prow: is my understanding correct that we will need to find a cluster to host this? or is their provision for piggybacking multiple projects onto a single prow?

A single prow instance is used for all k8s projects. https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md has more details on how to use it.

@starpit @paulcastro There are few more things we need to get out of the way before we can migrate the repo.

Note: if your name is listed above, could you please sign the CNCF CLA so that we can migrate the Kui repo to Kubernetes? Instructions on how to sign the CLA can be found here. Thank you! :)

@starpit @paulcastro We'll need to wait for a few weeks to see if any of the folks listed below sign the CLA. If there are outliers who have not signed the CLA, you can either: 1) remove the file if that's possible - https://github.com/kubernetes/org/issues/599#issuecomment-477822766 2) add a NOTICE file - https://github.com/kubernetes/org/issues/2182#issuecomment-740373871

joshuaauerbachwatson commented 3 years ago

Hi. I am listed as someone who needs to sign a new CLA. I long ago stopped being an active contributor to the kui core and would prefer not to go through these additional steps if it can be avoided. It sounds like you can just delete me as a contributor.

LouisStAmour commented 3 years ago

Signed :)

abdonrd commented 3 years ago

Signed!

ujibang commented 3 years ago

Signed!

Andrea Di Cesare Partner at SoftInstigate https://softinstigate.com/ Via Copernico 38, 20125 Milano (Italy) Mobile: +39 329 737 6417 Skype: ujibang

The company behind RESTHeart https://restheart.org, the Runtime for Microservices with Instant Data API on MongoDB

Il giorno gio 4 feb 2021 alle ore 17:07 Abdón Rodríguez Davila < notifications@github.com> ha scritto:

Signed!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/org/issues/2461#issuecomment-773421103, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUO2VZ2EBTZD5Z7R3LFTYDS5LA4RANCNFSM4WR7NRDQ .

jesusprubio commented 3 years ago

Signed!

myan9 commented 3 years ago

@nikhita, thanks for the help! We've done the Copyright header and Notice file. We're investigating on travis status check via prow. Currently Kui is using travis-ci for testing, so we want to configure prow to merge a PR when travis tests pass. Does the following configuration code against test-infra/config/prow/config.yaml look good to you? Does required_status_checks mean that prow will check the travis test result as long as the repo is travis enabled? We looked a couple of repos that specify travis status check in the config.yaml, but somehow prow merge PRs even if those repo no longer use travis. That's why we're a bit confused... Thank you!

  kui:
       required_status_checks:
           contexts:
           - continuous-integration/travis-ci
nikhita commented 3 years ago

Does the following configuration code against test-infra/config/prow/config.yaml look good to you?

Yes, this looks good!

Does required_status_checks mean that prow will check the travis test result as long as the repo is travis enabled? We looked a couple of repos that specify travis status check in the config.yaml, but somehow prow merge PRs even if those repo no longer use travis.

Yes, as long as travis is enabled in your repo and you specify required_status_checks in config.yaml, PRs will merge only if the travis check is green.

As a project, we encourage writing prow jobs instead of using travis so I'd recommend looking at migrating to prow entirely. You can find the docs here.

myan9 commented 3 years ago

@nikhita, thanks for the clarification! We'll continue the prow work once the PR is merged. We just finished the last round of cleaning up Copyright headers. Could you check if we're g2g? Thanks a lot!

nikhita commented 3 years ago

@myan9 just a few more things, sorry :(

swinslow commented 3 years ago

@nikhita 👋

One thing I note looking at the contributors listed above (setting aside those who have signed since then) is that several appear to work for existing k8s contributors like IBM, Red Hat and VMware. If someone from those companies can confirm here that their contributions can be treated as covered under those companies' existing signed CNCF CLAs, that would take care of them.

For the remainder, if there isn't a path forward to getting them to sign the CLA, then yes, I believe the project's practice is to include a NOTICE file with the language that was used recently for another repo in a similar situation.

starpit commented 3 years ago

@swinslow thanks for the help. We have I think a final list of CLA non-signers, and have added them to a NOTICE file as follows:

Submitted on behalf of a third-party: ImgBotApp “ImgBotApp” Submitted on behalf of a third-party: Joshua “joshuaauerbachwatson” Auerbach Submitted on behalf of a third-party: Yeray “ydarias” Darias Submitted on behalf of a third-party: Darío “kant” Hereñú Submitted on behalf of a third-party: Nirvana “nirvana-flam” Flame

In terms of contributions: 1) these are simple image optimizations, to reduce the size of files, and done by an automated bot 2) these contributions amount to a few lines of code that create a file if the thus-named file does not yet exist 3) are to .github template files, e.g. for new bug/new issue 4 and 5) minor changes to the README.md

Will the NOTICE file suffice for these? Thanks!

spiffxp commented 3 years ago

/milestone v1.21

swinslow commented 3 years ago

Hi @starpit, yes, these sound like minor contributions, and given past practice I think it would be fine to proceed with listing them in the NOTICE file as you described. Thanks!

nikhita commented 3 years ago

@starpit @myan9 @mark-nc can you create an issue to apply for membership to the @kubernetes-sigs GitHub org? Only members can approve PRs once the repo has been migrated. Instructions are here - https://github.com/kubernetes/community/blob/master/community-membership.md#member

I think we're good to go after that :+1:

mark-nc commented 3 years ago

@nikhita Do we open one PR for all three of us, or one PR for each? The link you provided also mentions @-ing two sponsors in the PR. Who are our sponsors?

mark-nc commented 3 years ago

Never mind.....discussed this with @starpit

starpit commented 3 years ago

Update: the three Kubernetes Memberships have been approved and accepted!

https://github.com/kubernetes/org/issues/2572 https://github.com/kubernetes/org/issues/2573 https://github.com/kubernetes/org/issues/2574

nikhita commented 3 years ago

@starpit Yay! If you can add me as an admin to the IBM/kui repo, I can help migrate it to k-sigs. :)

starpit commented 3 years ago

@nikhita done 👍

nikhita commented 3 years ago

@starpit I still don't see the Settings tab for the kui repo (admins should be able to see this) :thinking:

Edit: worked with @starpit on slack to fix this

nikhita commented 3 years ago

Repo has been migrated - https://github.com/kubernetes-sigs/kui :rocket:

@starpit @myan9 @mark-nc Thank you so much for your patience in getting this to the finish line!

I've also created two more PRs:

Once both PRs merge, we can close this issue.

nikhita commented 3 years ago

All PRs have merged and teams have been granted access. Closing.