kubernetes / org

Meta configuration for Kubernetes Github Org
Apache License 2.0
242 stars 680 forks source link

new staging repo: k8s.io/dynamic-resource-allocation #3821

Closed pohly closed 1 year ago

pohly commented 1 year ago

From https://groups.google.com/g/kubernetes-sig-architecture/c/DkKQyuUrj9Y:

The dynamic resource allocation implementation is under review for inclusion into Kubernetes 1.26 as new alpha feature. The full set of commits is pending in https://github.com/kubernetes/kubernetes/pull/111023.

It contains code that is used in-tree and out-of-tree. Initially we thought that we would publish such helper code later, but NVIDIA already started using it in their prototype of a dynamic resource allocation driver, therefore it makes sense to publish it properly already with Kubernetes 1.26.

Therefore I would like to request a new staging repo "k8s.io/dynamic-resource-allocation" where we will publish these helper packages. In some earlier revision I had the code under "k8s.io/component-helpers", but it changed the dependencies of that module. IMHO a separate staging repo is cleaner. It should be owned by SIG Node, with the set of people working on dynamic resource allocation as reviewers. SIG Node leads would be approvers plus Kevin and myself.

There have been no comments there, so I suppose there are no objections and we can proceed.

/cc @thockin (in case that explicit approval is needed)

klueska commented 1 year ago

/assign @derekwaynecarr

This needs sig-node-leads approval as per this slack conversation: https://kubernetes.slack.com/archives/C01672LSZL0/p1667751787905519

klueska commented 1 year ago

/approve (as sig-node-approver)

dchen1107 commented 1 year ago

/lgtm /approve

alculquicondor commented 1 year ago

I think this needs resolution on https://github.com/kubernetes/kubernetes/pull/111023#issuecomment-1309058680

johnbelamaric commented 1 year ago

/approve

mrbobbytables commented 1 year ago

repo created: https://github.com/kubernetes/dynamic-resource-allocation PR for branch protection: https://github.com/kubernetes/test-infra/pull/27980 Final step will be completed once PR in k/k is merged.

/assign

pohly commented 1 year ago

The PR has been merged.

Publishing bot also was updated: https://github.com/kubernetes/publishing-bot/pull/300

mrbobbytables commented 1 year ago

I think everything is done as far as getting the repo squared away.

The only administrative action left is to add it to k/community listed under a subproject

Would it be a new one or should it be listed under one of the others?

klueska commented 1 year ago

Let me ask what people prefer in the sig-node meeting today.

klueska commented 1 year ago

We discussed this in the sig-node meeting on Tuesday.

The consensus was for me to create a new subproject called resource-management which will absorb the existing noderesourcetopology-api subproject and include both this new staging repo and the repo that will result from my recent request for a kubernetes-sigs/dra-example-driver repo.

The first step is to open a PR against https://github.com/kubernetes/community to update the README with the new organization. What are the following steps? It looks like maybe an update to https://github.com/kubernetes/community/blob/master/sigs.yaml as well? Anything else?

klueska commented 1 year ago

PR to add the above: https://github.com/kubernetes/community/pull/6970

klueska commented 1 year ago

With the merging of https://github.com/kubernetes/community/pull/6970, I assume this issue can now be closed?

mrbobbytables commented 1 year ago

yup!

/close

k8s-ci-robot commented 1 year ago

@mrbobbytables: Closing this issue.

In response to [this](https://github.com/kubernetes/org/issues/3821#issuecomment-1323873032): >yup! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.