search

kubernetes / org

Meta configuration for Kubernetes Github Org
Apache License 2.0
243 stars 691 forks source link

REQUEST: Create new repository: kubernetes/cel-admission-webhook #4146

Closed cici37 closed 1 year ago

cici37 commented 1 year ago

New repo, staging repo, or migrate existing

new repository

Is it a staging repo?

yes

Requested name for new repository

cel-admission-webhook

Which Organization should it reside

kubernetes

Who should have admin access?

jpbetz, cici37

Who should have write access?

jpbetz, cici37

Who should be listed as approvers in OWNERS?

jpbetz, cici37, alexzielenski, jiahuif

Who should be listed in SECURITY_CONTACTS?

jpbetz, cici37, alexzielenski, jiahuif

What should the repo description be?

Kubernetes CEL for Admission Control implementation(KEP) is in Alpha in Kubernetes 1.26. This repo is to help interest group to try on the feature early by bypassing feature gate/API restrictions.

What SIG and subproject does this fall under?

this is a new subproject for sig-apimachiniery

Please provide references to appropriate approval for this new repo

The request is discussed in sig architecture meeting on April 6th and has been approved by both sig architecture(https://github.com/kubernetes/org/issues/4146#issuecomment-1499466542) and sig apimachinery(https://github.com/kubernetes/org/issues/4146#issuecomment-1499645954) leads.

Additional context for request

No response

dims commented 1 year ago

+1 from me!

tallclair commented 1 year ago

I'd suggest decoupling this from the validating part, since we plan to eventually add mutating admission, and it would be nice to use the same repo for that. Maybe cel-admission-webhook? Or will there be artifacts other than the webhook implementation tied to this?

mrbobbytables commented 1 year ago

/assign @deads2k @lavalamp for approval

lavalamp commented 1 year ago

Sounds good to me, but can you answer Tim's question?

cici37 commented 1 year ago

I'd suggest decoupling this from the validating part, since we plan to eventually add mutating admission, and it would be nice to use the same repo for that. Maybe cel-admission-webhook? Or will there be artifacts other than the webhook implementation tied to this?

Thanks for the suggestion! I have updated the repo name. It is mainly webhook with controllers(there might be a separate controller for status update besides admission controller). cel-admission-webhook makes sense to me

lavalamp commented 1 year ago

/approve

cici37 commented 1 year ago

Hey, with the approval, I am wondering if anyone I should ping for the actual work of the repo creation? Thank you :)

/cc @nikhita since I saw you helped with the previous similar issues. Or would you mind helping with redirecting to the right person? Thank you :)

mrbobbytables commented 1 year ago

/assign

mrbobbytables commented 1 year ago

repo has been added: github.com/kubernetes/cel-admission-webhook teams added: https://github.com/kubernetes/org/pull/4176 sigs.yaml updated: https://github.com/kubernetes/community/pull/7264

once both those are merged and teams granted permission, this should be good to close 👍

cici37 commented 1 year ago

Both of the above PRs are merged and repo created. Thank you!