search

kubernetes / perf-tests

Performance tests and benchmarks
Apache License 2.0
899 stars 536 forks source link

Feature addition to network benchmark tests #2876

Open ritwikranjan opened 2 months ago

ritwikranjan commented 2 months ago

What would you like to be added: I was looking into the network benchmarking tests available under /network/benchmarks/netperf. The tests present there are pretty old and very restrictive in how we study and publish them. Adding new test is not very trivial and there are a lot of conditionals involved. I was thinking of cleaning the way these network tests are written and also add additional output options like json which can be used to save and publish much more information than it do currently.

Why is this needed: This will make the tests more useful, easy to change, and more developer-friendly.

aojea commented 2 months ago

@ritwikranjan I will happy to review a new proposal, a google doc or something similar can work

ritwikranjan commented 2 months ago

Sounds great, I will write a proposal and send it here!

ritwikranjan commented 2 months ago

Hey @aojea, please find the doc attached, if it looks good I'll start working on a PR. proposal_perf_tests.docx

ritwikranjan commented 2 months ago

I have created a PR for first of a few changes I am planning to do on my fork. Feel free to take a look and suggest changes and improvements.

https://github.com/ritwikranjan/perf-tests/pull/1

I will make all the changes on my fork and open an upstream PR.

ritwikranjan commented 3 weeks ago

Bumping up the thread, Hey @aojea did you had the chance to take a look at the proposal?

aojea commented 3 weeks ago

Bumping up the thread, Hey @aojea did you had the chance to take a look at the proposal?

can you put the proposal in a shareable format? google docs, hackcmd or even a PR should be valid,

ritwikranjan commented 3 weeks ago

I have opened a PR #2969 with majority of the changes I have put in the proposal and I am going to make the proposal document in an online format as well. Let me know if this link works: https://1drv.ms/w/s!AlRV0Mo2jG1lg6RkJp4NRLNw9IOZNg?e=H7Fhdd, otherwise I will port it to google docs!