search

kubernetes / publishing-bot

Code behind the robot to publish from staging to real repositories.
Apache License 2.0
84 stars 82 forks source link

Prune unused replace directives #415

Closed liggitt closed 7 months ago

liggitt commented 7 months ago

Fixes https://github.com/kubernetes/publishing-bot/issues/214

This is the same logic used to prune unused replace directives from the main kubernetes/kubernetes repo at https://github.com/kubernetes/kubernetes/blob/master/hack/update-vendor.sh#L355-L361

/hold for testing

thockin commented 7 months ago

Manually verified

/lgtm /approve

dims commented 7 months ago

/test pull-publishing-bot-test-kubernetes-master

liggitt commented 7 months ago

/hold cancel

dims commented 7 months ago

/approve

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/publishing-bot/blob/master/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thockin commented 7 months ago

This didn't seem to work: https://github.com/kubernetes/kubernetes/issues/123933#issuecomment-2022763576

@dims @mohitsharma-in - I have no viz into how this is actually run - is the bot deployed with the latest commits?

liggitt commented 7 months ago

@dims dug into logs and we found where the replace directives were getting added back. Followup fix in https://github.com/kubernetes/publishing-bot/pull/416