kubernetes / registry.k8s.io

This project is the repo for registry.k8s.io, the production OCI registry service for Kubernetes' container image artifacts
https://registry.k8s.io
Apache License 2.0
403 stars 73 forks source link

Submit a Simplified Chinese translation file for README #260

Closed Zhoneym closed 1 year ago

Zhoneym commented 1 year ago

Submit a Simplified Chinese translation file for README

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 year ago

Welcome @Zhoneym!

It looks like this is your first PR to kubernetes/registry.k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/registry.k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @Zhoneym. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Zhoneym Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/registry.k8s.io/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BenTheElder commented 1 year ago

Hmm, without an active program to manage this, it seems it will just fall out of sync with our existing docs.

Reaching out to SIG docs who do maintain translations for kubernetes/website.

sftim commented 1 year ago

/hold

We don't have reviewers and approvers who can review and maintain this document; nor do we plan to.

OK to unhold if we do have a team of SIG Release approvers who can maintain Chinese and would like this README to exist with localized content.

reylejano commented 1 year ago

I agree with @sftim that SIG Docs does not have reviewers and approvers to maintain this and is outside the scope of the zn localization team

@Zhoneym , you can contact the SIG Docs zh localization team on the #documentation-docs-zh on Kubernetes Slack

I'm ok to close this PR unless SIG Release would like the README localized and has reviewers/approvers to maintain

mrbobbytables commented 1 year ago

One other potential thought, would it be worth adding a page somewhere on k8s.io about registry.k8s.io, the stability guarantees and basic troubleshooting? That would keep it in a place where localization drift could be tracked.

sftim commented 1 year ago

One other potential thought, would it be worth adding a page somewhere on k8s.io about registry.k8s.io, the stability guarantees and basic troubleshooting? That would keep it in a place where localization drift could be tracked.

Yes, that is a good idea. The (English) README can link there, too.

Might end up being two pages as troubleshooting docs are separated out.

BenTheElder commented 1 year ago

Let's plan to do that instead. Thank you all!