krel release-notes sometimes errors when the user exits their editor

JamesLaverack commented 11 months ago

What happened:

Sometimes, intermittently and infrequently, the krel release notes tool will report an error and exit when a user exits their editor when editing release notes.

Users report errors such as:

- Fix note for PR #97252? (y/N) (1/10) 
y
INFO Opening file with editor [vi /var/folders/94/yvfr6pns4vxd1bz_cr2nwpkc0000gn/T/release-notes-map-1064630614.yaml] 
FATA creating Draft PR: while running release notes fix flow: while editing release note: while launching editor: there was a problem with the editor "vi"

What you expected to happen:

For krel to not error when a user exits their editor normally.

How to reproduce it (as minimally and precisely as possible):

No known reliable reproduction. But it's been reported by multiple users, multiple years apart. Often seen when using vi and not using other editors, but It's not clear if it's anything to do with vi or just because vi is the default.

Anything else we need to know?:

N/A

Environment:

N/A

JamesLaverack commented 11 months ago

Added https://github.com/kubernetes-sigs/release-utils/pull/98 to add more logging. In existing error logs the error itself isn't exposed in the log line. Hopefully this will help with debugging the next time this comes up.

JamesLaverack commented 11 months ago

/priority backlog

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

JamesLaverack commented 8 months ago

This is waiting to see if it recurs. It could be some time.

/remove-lifecycle stale /lifecycle frozen

kubernetes / release