kubernetes / release

Release infrastructure for Kubernetes and related components
Apache License 2.0
485 stars 502 forks source link

Dependency update - Golang 1.23 #3650

Open cpanato opened 4 months ago

cpanato commented 4 months ago

Tracking info

Link to any previous tracking issue: https://github.com/kubernetes/release/issues/3280

Golang mailing list announcement: https://groups.google.com/g/golang-announce/c/8ciOP5ve_CM/m/fg9_BQpdFgAJ

SIG Release Slack thread: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1719215856518939

Work items for go1.23.0

After go-runner image promotion

Work items for go1.23rc1

After go-runner image promotion

Work items for go1.23rc2

After go-runner image promotion

After kube-cross and distroless-iptables image promotions

Note This update may require an update to go.sum files, for example: https://github.com/kubernetes/kubernetes/pull/118507 This will require an API Review approval.

After kubernetes/kubernetes (master) has been updated

Follow-up items

/assign cc: @kubernetes/release-engineering

cpanato commented 4 months ago

cc @MadhavJivrajani @liggitt

MadhavJivrajani commented 4 months ago

Tracking PRs related to go1.23 that we would need to pick to release branches as part of an eventual update to go1.23:

Tracking verification of conditions for bumping go1.21 on release branches:


Tracking the PR that actually bumps to go1.22:

cpanato commented 4 months ago

RC2 released: https://groups.google.com/g/golang-announce/c/jW315Nz132s/m/WqkCDaiVBQAJ

pacoxu commented 3 months ago

https://github.com/kubernetes/release/pull/3685 post run of this PR failed:

liggitt commented 2 months ago

go 1.23.0 is out now, can rebump master to 1.23 now 🎉

cpanato commented 2 months ago

all done

/close

k8s-ci-robot commented 2 months ago

@cpanato: Closing this issue.

In response to [this](https://github.com/kubernetes/release/issues/3650#issuecomment-2327485150): >all done > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
liggitt commented 2 months ago

should we keep this open for tracking changes required for go 1.23 (like https://github.com/kubernetes/release/issues/3280#issuecomment-1726964825), and backport of 1.23 to release branches?

cpanato commented 2 months ago

/reopen

k8s-ci-robot commented 2 months ago

@cpanato: Reopened this issue.

In response to [this](https://github.com/kubernetes/release/issues/3650#issuecomment-2329364917): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
liggitt commented 2 months ago

Can we add an item to https://github.com/kubernetes/release/issues/3650#issuecomment-2211373351 to pick the godebug default=go1.x commit from https://github.com/kubernetes/kubernetes/pull/127271 to release branch go.mod files?

xref https://tip.golang.org/doc/godebug#default