search

kubernetes / release

Release infrastructure for Kubernetes and related components
Apache License 2.0
485 stars 502 forks source link

[script] Retrieve proper author and PR type when generating release notes #3746

Open mimowo opened 2 months ago

mimowo commented 2 months ago

What would you like to be added:

The release-notes script would retrieve the author of the fix from the parent PR. Currently, the script retrieves the https://github.com/k8s-infra-cherrypick-robot as the author.

Similarly (less important, because it does not need to be repeated when re-generating notes) it would be great to retrieve the PR type (like kind or feature).

Why is this needed:

It takes time to manually adjust the release notes. Sometimes the notes are regenerated, and in total it can take something like 30min of manual chore. Similarly, we need to manually annotate type for the cherry-picks (/kind bug).

Example release in Kueue: https://github.com/kubernetes-sigs/kueue/issues/2985 For this we have to manually adjust the notes. Example cherry-pick PR: https://github.com/kubernetes-sigs/kueue/pull/2879.

mimowo commented 2 months ago

/cc @alculquicondor

mbobrovskyi commented 2 months ago

/assign

mbobrovskyi commented 2 months ago

Looks like we have initial logic to get original PR on https://github.com/kubernetes/release/pull/3468. It is not fully cover our problem but it would be great to merge it first.

mimowo commented 2 months ago

I see, thank you for letting us know. I'm wondering if we could tidy up the initial pr for the ease of reviewing