search

kubernetes / release

Release infrastructure for Kubernetes and related components
Apache License 2.0
485 stars 504 forks source link

bump distroless-iptables to use go1.22.9 and go1.23.3 #3829

Closed cpanato closed 2 weeks ago

cpanato commented 2 weeks ago

What type of PR is this?

/kind cleanup /kind feature

What this PR does / why we need it:

/assign @xmudrii @saschagrunert @Verolop cc @kubernetes/release-managers

Which issue(s) this PR fixes:

xref: https://github.com/kubernetes/release/issues/3819

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- bump distroless-iptables to use go1.22.9 and go1.23.3
xmudrii commented 2 weeks ago

@cpanato What's the reason for bumping the minor version for these images? I don't remember that we were doing that earlier for Go updates. Are there any other changes? If yes, should we mention them in the release note?

cpanato commented 2 weeks ago

@cpanato What's the reason for bumping the minor version for these images? I don't remember that we were doing that earlier for Go updates. Are there any other changes? If yes, should we mention them in the release note?

not sure if a follow you? we bumped go-runner to 2.4.0 just using here, do you want to bump minor for distroless as well? if yes, i will need to build 2.3.1 for go 1.22.x as we cannot bump the 0.5.x for distroless, but that will be deprecated soon

saschagrunert commented 2 weeks ago

/hold

for clarification on the version

xmudrii commented 2 weeks ago

@cpanato I was wondering why is the go-runner version bumped from v2.3.1 to v2.4.0, but I see that's because of #3820 and #3816, which makes sense! /lgtm /approve /hold cancel

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/release/blob/master/OWNERS)~~ [cpanato,saschagrunert,xmudrii] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment