Generated by robot - Githubissues

caesarxuchao commented 7 years ago

All 5 PRs generated in the same run of the robot: https://github.com/kubernetes/client-go/pull/140 https://github.com/kubernetes/apimachinery/pull/10 https://github.com/kubernetes/apiserver/pull/4 https://github.com/kubernetes/kube-aggregator/pull/4 https://github.com/kubernetes/sample-apiserver/pull/2

k8s-ci-robot commented 7 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Instructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-request-commands.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).

sttts commented 7 years ago

Same here: a real vendor/ dir including k8s.io/* should exist.

deads2k commented 7 years ago

Same here: a real vendor/ dir including k8s.io/* should exist.

It would be nice, but being able to auto-sync is so helpful, I'd take it without.

lgtm

luxas commented 7 years ago

It would be nice, but being able to auto-sync is so helpful, I'd take it without.

@deads2k Why wouldn't you be able to auto-sync from the k8s core anyway? Do you provide any helper scripts in the repos for now to restore the state to something usable once downloaded?

deads2k commented 7 years ago

Do you provide any helper scripts in the repos for now to restore the state to something usable once downloaded?

In theory there's nothing special needed. godep restore should just work.

deads2k commented 7 years ago

merging in preparation for turning on the auto-sync scripts

kubernetes / sample-apiserver

Generated by robot #2