Closed caesarxuchao closed 7 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.
Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
Same here: a real vendor/
dir including k8s.io/*
should exist.
Same here: a real vendor/ dir including k8s.io/* should exist.
It would be nice, but being able to auto-sync is so helpful, I'd take it without.
lgtm
It would be nice, but being able to auto-sync is so helpful, I'd take it without.
@deads2k Why wouldn't you be able to auto-sync from the k8s core anyway? Do you provide any helper scripts in the repos for now to restore the state to something usable once downloaded?
Do you provide any helper scripts in the repos for now to restore the state to something usable once downloaded?
In theory there's nothing special needed. godep restore should just work.
merging in preparation for turning on the auto-sync scripts
All 5 PRs generated in the same run of the robot: https://github.com/kubernetes/client-go/pull/140 https://github.com/kubernetes/apimachinery/pull/10 https://github.com/kubernetes/apiserver/pull/4 https://github.com/kubernetes/kube-aggregator/pull/4 https://github.com/kubernetes/sample-apiserver/pull/2