kubernetes / sample-cli-plugin

Sample kubectl plugin
Apache License 2.0
291 stars 108 forks source link

Add sample krew plugin manifest #2

Open ahmetb opened 5 years ago

ahmetb commented 5 years ago

@soltysh has brought up this idea: why don't we have also include a Krew (https://sigs.k8s.io/krew) plugin manifest in this plugin sample?

To do this, we would need to:

  1. Provide a prebuilt archive file containing cross-platform binaries of this repo (since this program is in Go) on GitHub releases section (or somewhere else on the internet).

  2. Provide a command to built this archive file locally (make or hack/build-plugin-package.sh)

  3. Add a sample-plugin.yaml to the root, that's pinning to a particular tag of the binary release archive and its sha256 sum (since we can't update those values as part of the release easily).

Once we do these, anyone cloning this repository can try the sample manifest like:

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

corneliusweig commented 5 years ago

/remove-lifecycle stale

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

ahmetb commented 4 years ago

/lifecycle frozen