ViviLearns2Code
commented
3 years ago Hello, I don't think there is a straight-forward way to do this. client-go allows you to do metrics, but you need to inject your own metrics provider to get them. You can see how this is done if you look up the implementation in controller-runtime: https://github.com/kubernetes-sigs/controller-runtime/tree/master/pkg/metrics
Ex: Workqueue metrics These are the client-go metrics for workqueues - you can see that by default it uses a dummy metrics provider
/* https://github.com/kubernetes/client-go/blob/master/util/workqueue/metrics.go */
type noopMetricsProvider struct{}
func (_ noopMetricsProvider) NewDepthMetric(name string) GaugeMetric {
return noopMetric{}
}
/* more methods */
var globalMetricsFactory = queueMetricsFactory{
metricsProvider: noopMetricsProvider{},
}
type queueMetricsFactory struct {
metricsProvider MetricsProvider
onlyOnce sync.Once
}
func (f *queueMetricsFactory) setProvider(mp MetricsProvider) {
f.onlyOnce.Do(func() {
f.metricsProvider = mp
})
}Now in your code, you need to set that metrics provider to something useful that you define yourself
/* https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/metrics/workqueue.go */
var (
depth = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Subsystem: WorkQueueSubsystem,
Name: DepthKey,
Help: "Current depth of workqueue",
}, []string{"name"})
)
func init() {
Registry.MustRegister(depth)
workqueue.SetProvider(workqueueMetricsProvider{})
}
type workqueueMetricsProvider struct{}
func (workqueueMetricsProvider) NewDepthMetric(name string) workqueue.GaugeMetric {
return depth.WithLabelValues(name)
}
fejta-bot
k8s-triage-robot
k8s-ci-robot
Is there an easy way to add prometheus metrics to the controller?