`./hack/update-codegen.sh` fails on pristine checkout

mamachanko commented 2 years ago

When running ./hack/update-codegen.sh on a pristine checkout (currently 76c5360), it fails with bash: ../code-generator/generate-groups.sh: No such file or directory.

See:

$ docker run \
  --rm \
  -it \
  golang:1.17.6 \
  bash -c 'git clone https://github.com/kubernetes/sample-controller && cd sample-controller && git rev-parse && ./hack/update-codegen.sh'
Cloning into 'sample-controller'...
remote: Enumerating objects: 23975, done.
remote: Counting objects: 100% (2063/2063), done.
remote: Compressing objects: 100% (596/596), done.
remote: Total 23975 (delta 1685), reused 1819 (delta 1456), pack-reused 21912
Receiving objects: 100% (23975/23975), 11.34 MiB | 6.46 MiB/s, done.
Resolving deltas: 100% (16240/16240), done.
76c5360f8cd39f4da41c8b58bcdfa10237d93c0c
bash: ../code-generator/generate-groups.sh: No such file or directory

I understand that client code generation is not straightforward. However, it would be nice if sample-controller could show the way here.

Thanks y'all! ❤️

leonharetd commented 2 years ago

you could run go mod vendor (in Fetch sample-controller)

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mamachanko commented 2 years ago

/close

k8s-ci-robot commented 2 years ago

@mamachanko: Closing this issue.

In response to [this](https://github.com/kubernetes/sample-controller/issues/83#issuecomment-1186947015): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kubernetes / sample-controller

`./hack/update-codegen.sh` fails on pristine checkout #83