search

kubernetes / sig-release

Repo for SIG release
Apache License 2.0
521 stars 379 forks source link

Add internal schedule for release notes PRs #2499

Closed npolshakova closed 3 weeks ago

npolshakova commented 1 month ago

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This adds an example for defining release notes draft PR merge deadline. Currently, the timeline only defines when a branch is created, and we assume to get the PR done sometime before the next branch is made. This would be only internally enforced and used to give status updates.

Previously Release Notes Leads have created similar schedules for assigning shadows to "own" a specific release: https://docs.google.com/spreadsheets/d/1xNNWdh-hFTVgg-zebp0-DdV-gCnx5l3uUv3RikjAzBg/edit?usp=sharing

The 1.30 end of release retro suggested adding a release notes draft PR merge deadline that would be tied to status reports during release team update meetings.

Which issue(s) this PR fixes:

https://github.com/kubernetes/sig-release/issues/2498

rashansmith commented 1 month ago

Hey @npolshakova, great job on getting this done! Overall it looks good, and I've added a few comments. Let me know what you think!

rashansmith commented 1 month ago

/lgtm

rashansmith commented 1 month ago

/assign @harshanarayana

Priyankasaggu11929 commented 1 month ago

/lgtm /approve

/hold

Priyankasaggu11929 commented 1 month ago

@npolshakova, please feel free to remove hold whenever PR is ready to merge. :slightly_smiling_face:

Thanks for the updates! :pray:

Priyankasaggu11929 commented 3 weeks ago

/unhold

/approve /lgtm

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npolshakova, Priyankasaggu11929, rashansmith, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[release-team/role-handbooks/release-notes/OWNERS](https://github.com/kubernetes/sig-release/blob/master/release-team/role-handbooks/release-notes/OWNERS)~~ [Priyankasaggu11929,saschagrunert] - ~~[releases/release-1.31/OWNERS](https://github.com/kubernetes/sig-release/blob/master/releases/release-1.31/OWNERS)~~ [Priyankasaggu11929,saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment