search

kubernetes / sig-security

Process documentation, non-code deliverables, and miscellaneous artifacts of Kubernetes SIG Security
Apache License 2.0
172 stars 58 forks source link

Move Snyk Scripts from k/test-infra to k/sig-security/sig-security-tooling #60

Open PushkarJ opened 2 years ago

PushkarJ commented 2 years ago

As we learnt from https://github.com/kubernetes/test-infra/pull/26896#discussion_r932628360 it is possible for prow to pick up shell scripts outside of k/test-infra.

Moving the script that is present here: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-security-trusted.yaml#L29-L87 into a dedicated shell script with name build-deps-and-release-images.sh under k/sig-security/sig-security-tooling/scanning would be great for faster iteration and approvals and reviews can be managed within SIG Security members.

/sig security /good-first-issue /help

k8s-ci-robot commented 2 years ago

@PushkarJ: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes/sig-security/issues/60): >As we learnt from https://github.com/kubernetes/test-infra/pull/26896#discussion_r932628360 it is possible for prow to pick up shell scripts outside of `k/test-infra`. > >Moving the script that is present here: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-security-trusted.yaml#L29-L87 into a dedicated shell script with name `build-deps-and-release-images.sh` under `k/sig-security/sig-security-tooling/scanning` would be great for faster iteration and approvals and reviews can be managed within SIG Security members. > >/sig security >/good-first-issue >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
PushkarJ commented 2 years ago

/hold for https://github.com/kubernetes/test-infra/pull/27309

lakshya8066 commented 2 years ago

Hi @PushkarJ is this issue open for contribution?

PushkarJ commented 2 years ago

Yes the PR blocking it is merged. So you can work on this if you'd like

lakshya8066 commented 2 years ago

/assign

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tabbysable commented 7 months ago

/remove-lifecycle stale

Dylan-G-Roberts commented 2 weeks ago

/assign