Closed justaugustus closed 2 years ago
This is roughly a no-op, so the changes process should not apply here. /assign @parispittman @dims @mrbobbytables
/hold for other reviewers and approvers
/approve /lgtm
I personally agree this is a no-op. However I think you should count this as part of the other change for the purpose of following the change policy, which does not make an exception for no-op changes.
lgtm
I also read this as a noop and explicitly states and links current policy and practices.
LGTM
@kubernetes/steering-committee -- Reviews have been addressed and we all seem to be in agreement about this being a no-op.
Just needs another LGTM. /hold cancel
/lgtm
/hold We haven't set a vote on this yet. Holding per our change process.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dims, justaugustus
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LGTM
lgtm
lgtm here and in the meeting
/hold cancel
(Voted in today's meeting and 7/7 in favor of merging this) Let's try that hold cancel again... /hold cancel
These commits were peeled off of https://github.com/kubernetes/steering/pull/248, initially committed by @parispittman:
Co-authored-by: Stephen Augustus foo@auggie.dev
There are no content changes, outside of fixing up links and referencing existing process/procedure. cc: @kubernetes/steering-committee