kubernetes / steering

The Kubernetes Steering Committee
Apache License 2.0
86 stars 61 forks source link

charter: Add changes and election vacancies sections #249

Closed justaugustus closed 2 years ago

justaugustus commented 2 years ago

These commits were peeled off of https://github.com/kubernetes/steering/pull/248, initially committed by @parispittman:

Co-authored-by: Stephen Augustus foo@auggie.dev

There are no content changes, outside of fixing up links and referencing existing process/procedure. cc: @kubernetes/steering-committee

justaugustus commented 2 years ago

This is roughly a no-op, so the changes process should not apply here. /assign @parispittman @dims @mrbobbytables

dims commented 2 years ago

/hold for other reviewers and approvers

/approve /lgtm

lavalamp commented 2 years ago

I personally agree this is a no-op. However I think you should count this as part of the other change for the purpose of following the change policy, which does not make an exception for no-op changes.

parispittman commented 2 years ago

lgtm

cblecker commented 2 years ago

I also read this as a noop and explicitly states and links current policy and practices.

LGTM

justaugustus commented 2 years ago

@kubernetes/steering-committee -- Reviews have been addressed and we all seem to be in agreement about this being a no-op.

Just needs another LGTM. /hold cancel

dims commented 2 years ago

/lgtm

cblecker commented 2 years ago

/hold We haven't set a vote on this yet. Holding per our change process.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/steering/blob/main/OWNERS)~~ [dims,justaugustus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dims commented 2 years ago

LGTM

tpepper commented 2 years ago

lgtm

liggitt commented 2 years ago

lgtm here and in the meeting

justaugustus commented 2 years ago

/hold cancel

justaugustus commented 2 years ago

(Voted in today's meeting and 7/7 in favor of merging this) Let's try that hold cancel again... /hold cancel