search

kubernetes / system-validators

A set of system-oriented validators for kubeadm preflight checks.
Apache License 2.0
35 stars 26 forks source link

Clarify dependency hack #10

Closed odinuge closed 4 years ago

odinuge commented 4 years ago

We don't vendor deps, so we should not say we do.

We do vendor deps in k/k, but a lot of the small side repos (like k/test-infra) have stopped vendoring deps. Since we didn't do it from the beginning here, I suggest that we don't do it, and remove the vendor related code (done in this PR).

neolit123 commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, odinuge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/system-validators/blob/master/OWNERS)~~ [neolit123] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment