search

kubernetes / system-validators

A set of system-oriented validators for kubeadm preflight checks.
Apache License 2.0
35 stars 27 forks source link

Add preflight check for optional cgroups #11

Closed odinuge closed 4 years ago

odinuge commented 4 years ago

pids and hugetlb are optional, ref. https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/cgroup_manager_linux.go#L325

neolit123 commented 4 years ago

@odinuge i'm ok with this change but i need sig-node folks to confirm they approve of this. if you are not getting a review try asking in the #sig-node channel on k8s slack.

/hold /approve /sig node /cc @Random-Liu

neolit123 commented 4 years ago

@kubernetes/sig-node-pr-reviews @kubernetes/sig-cluster-lifecycle-pr-reviews

odinuge commented 4 years ago

/assign derekwaynecarr

odinuge commented 4 years ago

/cc @RobertKrawitz for working with pids

k8s-ci-robot commented 4 years ago

@odinuge: GitHub didn't allow me to request PR reviews from the following users: for, working, with, pids.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes/system-validators/pull/11#issuecomment-566513237): >/cc @RobertKrawitz for working with pids Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
odinuge commented 4 years ago

Updated the PR with comments now :smile:

odinuge commented 4 years ago

ping @neolit123

neolit123 commented 4 years ago

based on the discussion and review. /lgtm /hold cancel

thanks for the updates. to enable usage of this in k/k a new TAG for this repository and another PR in k/k is required.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, odinuge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/system-validators/blob/master/OWNERS)~~ [neolit123] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment