search

kubernetes / system-validators

A set of system-oriented validators for kubeadm preflight checks.
Apache License 2.0
34 stars 25 forks source link

PidLimits promoted to GA #18

Closed SergeyKanzhelev closed 4 years ago

SergeyKanzhelev commented 4 years ago

Follow up from https://github.com/kubernetes/kubernetes/pull/94140

neolit123 commented 4 years ago

Thanks! Lets hold this until the feature PR merges.

This also means we have to release a new Minor of this library and revendor it in k/k.

/lgtm /approve /hold

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/system-validators/blob/master/OWNERS)~~ [neolit123] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
neolit123 commented 4 years ago

/kind feature /priority important-longterm

k8s-ci-robot commented 4 years ago

@neolit123: The label(s) priority/ cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/kubernetes/system-validators/pull/18#issuecomment-681869524): >/kind feature >/priority important-longterm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
SergeyKanzhelev commented 4 years ago

PR in k/k got merged. I wonder if I can cancel hold on self-authored PR...

/hold cancel

neolit123 commented 4 years ago

@SergeyKanzhelev do you happen to know if there are other planned features from SIG node related to this repository?

SergeyKanzhelev commented 4 years ago

@SergeyKanzhelev do you happen to know if there are other planned features from SIG node related to this repository?

I don't think so after briefly looking thru the code. even for this change, cutting release is not critical as it is not a breaking change. So perhaps, this can wait in case something else will come up

neolit123 commented 4 years ago

ok, since this library's "release process" is a bit bottlenecked on my availability, i'd prefer if we cut the release now and re-vendor in k/k right away to unblock tests if needed(?).

and we can cut more releases here if needed for 1.20 later.

neolit123 commented 4 years ago

here is the new release: https://github.com/kubernetes/system-validators/releases/tag/v1.2.0

would you be able to send the PR to re-vendor?

here is an example commit on how we update the vendor: https://github.com/kubernetes/kubernetes/commit/8183787493472b2d9a7006f78da63cd589456f81

it uses the script: https://github.com/kubernetes/kubernetes/blob/master/hack/pin-dependency.sh

SergeyKanzhelev commented 4 years ago

here is the new release: https://github.com/kubernetes/system-validators/releases/tag/v1.2.0

would you be able to send the PR to re-vendor?

Yes, thank you for the detailed instructions!