search

kubernetes / system-validators

A set of system-oriented validators for kubeadm preflight checks.
Apache License 2.0
35 stars 27 forks source link

update OWNERS.md and add release guide in README.md #22

Closed neolit123 closed 3 years ago

neolit123 commented 3 years ago

first commit is an OWNERS update:

remove approvers to sync with https://github.com/kubernetes/kubernetes/pull/98547

please state if you object to these changes. applying lazy consensus next week ~4th of Feb.

@KentaTada i think you are not a member of the kubernetes github org? if so, i'd be happy to sponsor your membership. likely @odinuge can +1 as well.

https://github.com/kubernetes/community/blob/master/community-membership.md#requirements it requires sending a PR to k/org.

second commit adds a small release guide to README.md.

neolit123 commented 3 years ago

/kind cleanup documentation /cc @fabriziopandini /triage accepted /hold

KentaTada commented 3 years ago

@KentaTada i think you are not a member of the kubernetes github org? if so, i'd be happy to sponsor your membership. likely @odinuge can +1 as well.

I am not a member of the kubernetes github org. @neolit123 @odinuge Could you sponsor my membership? https://github.com/kubernetes/org/issues/2467

Thanks!

neolit123 commented 3 years ago

ok, once https://github.com/kubernetes/org/issues/2467 is closed we can proceed here. :+1:

neolit123 commented 3 years ago

/hold cancel

neolit123 commented 3 years ago

kubernetes/org#2467

merged, looking for LGTM again. instead of removing the old approvers moved them to "emeritus_approvers"

odinuge commented 3 years ago

/lgtm

Not sure if you want me to put it into tide now... But feel free to cancel hold if that was what you wanted! :tada: /hold

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, odinuge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/system-validators/blob/master/OWNERS)~~ [neolit123] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
KentaTada commented 3 years ago

Thank you for all your help. /hold cancel