search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.62k forks source link

Reduce top-level approvers to oncall and leads #10747

Closed fejta closed 5 years ago

fejta commented 5 years ago

I would like to propose shrinking https://github.com/kubernetes/test-infra/blob/master/OWNERS down to people who are go.k8s.io/oncall and/or https://github.com/kubernetes/community/tree/master/sig-testing chairs.

Ideally I would like to limit who can approve PRs that update prow to the people who are oncall for prow.

This would result in moving @michelle192837 @mithrav @shyamjvs approvals to various sub-dirs of the repo.

@stevekuznetsov @spiffxp any concerns here?

Michelle, Mithra, Shyam, can you let me know what sub-dirs you want to maintain approval for?

spiffxp commented 5 years ago

/milestone v1.14

I'm in favor of this, though I suspect there are some more subdirs we may want coverage on

Would recommend documenting this policy somewhere (comment in the OWNERS file? something in docs? something in k/community/sig-testing?)

michelle192837 commented 5 years ago

Sounds good! Just testgrid/ level approval seems fine for me

shyamjvs commented 5 years ago

Sgtm too. I'd ask for:

BenTheElder commented 5 years ago

We should leave comments in the OWNERS denoting why people are there and linking to any docs on this.

IMHO we should definitely expand sub-dir owners. Prow will give smarter PR assignment if we have appropriate directory owners. We have more of that today than we used to but have mostly leaned on top-level owners and still do to some extent.

mithrav commented 5 years ago

/docs for me mainly

On Mon, Jan 14, 2019 at 3:28 PM Benjamin Elder notifications@github.com wrote:

We should leave comments in the OWNERS denoting why people are there and linking to any docs on this.

IMHO we should definitely expand sub-dir owners. Prow will give smarter PR assignment if we have appropriate directory owners. We have more of that today than we used to but have mostly leaned on top-level owners and still do to some extent.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes/test-infra/issues/10747#issuecomment-454203511, or mute the thread https://github.com/notifications/unsubscribe-auth/AfNINGy1UhwHu3kLRLHjq9S24WmAN9pgks5vDRKrgaJpZM4Z_yUy .

-- Engineering Productivity Google Cloud Platform Sunnyvale