search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.83k stars 2.64k forks source link

verify-owners allowed adding a non-repo collaborator to helm/charts #15494

Closed fejta closed 4 years ago

fejta commented 4 years ago

https://github.com/hakman/charts/commits/4bf26601862700c2da25a82a2ee5aa6f7a2c0edf/stable/sematext-agent/OWNERS

/area prow /area prow/hook /kind oncall-hotlist

See https://github.com/helm/charts/issues/19410 for more info

Looks like we added this plugin to helm/charts on Oct 2018: https://github.com/kubernetes/test-infra/commit/5c2d099897271a73cfae6d9fd4654adbf76dbcef

This OWNERS file was created Feb 12 of this year, latest edit was Jul 9 2019: https://github.com/hakman/charts/commits/4bf26601862700c2da25a82a2ee5aa6f7a2c0edf/stable/sematext-agent/OWNERS

nikhita commented 4 years ago

This isn't a bug, helm/charts explicitly opts into skipping the collaborator check:

https://github.com/kubernetes/test-infra/blob/d6d702584f4cf72e7addbdb442640d054c78cdc3/config/prow/plugins.yaml#L33-L35

https://github.com/kubernetes/test-infra/blob/d6d702584f4cf72e7addbdb442640d054c78cdc3/prow/plugins/verify-owners/verify-owners.go#L124-L129

/remove-kind bug

nikhita commented 4 years ago

helm/charts explicitly opts into skipping the collaborator check

This was added in https://github.com/kubernetes/test-infra/pull/10164. @mattfarina is this something that is still desired for the helm/charts repo?

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

nikhita commented 4 years ago

Closing since this isn't a bug. Please reopen if the helm/charts configuration needs to be updated.

/close

k8s-ci-robot commented 4 years ago

@nikhita: Closing this issue.

In response to [this](https://github.com/kubernetes/test-infra/issues/15494#issuecomment-615344690): >Closing since this isn't a bug. Please reopen if the helm/charts configuration needs to be updated. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta commented 4 years ago

This is a bug in helm/charts' config -- github disallows assigning people who are not involved in the repo in some way