search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.63k forks source link

PR author becomes the bot when it's merged #16618

Closed chizhg closed 4 years ago

chizhg commented 4 years ago

What happened: For Knative projects, started from around 10AM PST. on Mar. 4th 2020, all PR authors became the knative-prow-robot, as shown in https://github.com/knative/serving/commits/master.

The PR author for Istio also changed to the bot, see https://github.com/istio/istio.io/commits/master.

What you expected to happen: The PR author should still be the one who created the PR.

Anything else we need to know?: This should be due to an API change in Github, but I wonder if the fix can be made in Tide.

/help /area prow/tide

k8s-ci-robot commented 4 years ago

@chizhg: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes/test-infra/issues/16618): > > > >**What happened**: >For Knative projects, started from around 10AM PST. on Mar. 4th 2020, all PR authors became the knative-prow-robot, as shown in https://github.com/knative/serving/commits/master. > >The PR author for Istio also changed to the bot, see https://github.com/istio/istio.io/commits/master. > >**What you expected to happen**: >The PR author should still be the one who created the PR. > >**Anything else we need to know?**: >This should be due to an API change in Github, but I wonder if we can make the fix in Tide. > >/help >/area prow/tide > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
clarketm commented 4 years ago

The problem is apparently GitHub platform-wide and specific to squash merging.

e.g.

alvaroaleman commented 4 years ago

This behavior doesn't make any sense and is IMHO a github bug. Merging something doesn't make the merging account the author of the change.

howardjohn commented 4 years ago

This is really annoying. I think its a github bug.. look at https://github.com/envoyproxy/envoy/commits/master, thats not even a robot its just someone pressing "merge" on github and its accredited to him. I sent a ticket to github, not sure if it will change anything

dims commented 4 years ago

yep. https://twitter.com/andyhayden1/status/1235593402709716992?s=19

clarketm commented 4 years ago

Until GitHub fixes this bug, orgs/repos using Prow can follow this pattern in Tide as mitigation. https://github.com/istio/test-infra/pull/2464

clarketm commented 4 years ago

GH reverted the change. https://github.community/t5/How-to-use-Git-and-GitHub/Authorship-of-merge-commits-made-by-Github-Apps-changed/td-p/48797/page/2

/close

k8s-ci-robot commented 4 years ago

@clarketm: Closing this issue.

In response to [this](https://github.com/kubernetes/test-infra/issues/16618#issuecomment-595664686): >GH reverted the change. https://github.community/t5/How-to-use-Git-and-GitHub/Authorship-of-merge-commits-made-by-Github-Apps-changed/td-p/48797/page/2 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.