Closed chizhg closed 4 years ago
@chizhg: This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help
command.
The problem is apparently GitHub platform-wide and specific to squash merging.
e.g.
This behavior doesn't make any sense and is IMHO a github bug. Merging something doesn't make the merging account the author of the change.
This is really annoying. I think its a github bug.. look at https://github.com/envoyproxy/envoy/commits/master, thats not even a robot its just someone pressing "merge" on github and its accredited to him. I sent a ticket to github, not sure if it will change anything
Until GitHub fixes this bug, orgs/repos using Prow can follow this pattern in Tide as mitigation. https://github.com/istio/test-infra/pull/2464
@clarketm: Closing this issue.
What happened: For Knative projects, started from around 10AM PST. on Mar. 4th 2020, all PR authors became the
knative-prow-robot
, as shown in https://github.com/knative/serving/commits/master.The PR author for Istio also changed to the bot, see https://github.com/istio/istio.io/commits/master.
What you expected to happen: The PR author should still be the one who created the PR.
Anything else we need to know?: This should be due to an API change in Github, but I wonder if the fix can be made in Tide.
/help /area prow/tide